7966 sd attach should not issue potentially slow scsi commands

Review Request #399 - Created March 13, 2017 and discarded

Yuri Pankov

Work by Hans Rosenfeld (mostly).

Move everything requiring sending SCSI commands to device out of initial attach routine and do the remaining work using taskq.

As we had the PM completely disabled in sd, I have fixed the PM paths as well for upstreaming. As we need to have pm-components available when finishing attach, install the initial property having all states for both "power conditition supported" and "start/stop" cases in sdattach(). Remap the "start/stop" power levels to the "power condition supported" ones, and update the property afterwards if needed in sd_setup_pm()->sd_update_pm_components(), so now a "start/stop" would look like the following:

name='pm-components' type=string items=3 dev=none
    value='NAME=spindle-motor' + '0=stopped' + '3=active'

This have been in production for quite some time.

I've retested the power stuff after having fixed it on a bunch of systems, where drives are not pm-capable at all, support only start/stop, and the desktop ones supporting power conditition.


  • 1
  • 0
  • 3
  • 4
Description From Last Updated
What is 'smart probing'? Robert Mustacchi Robert Mustacchi
Yuri Pankov
Robert Mustacchi
Yuri Pankov
Review request changed

Status: Discarded

Yuri Pankov

Closing this as Hans is now working for Joyent and will be able to upstream and answer all question better than me.

Andrew Stormont

I reviewed these changes months ago and completely forgot about them. Sorry! To me they look good, but please address others' concerns first.