Summary: |
|
||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
||||||||||||||||||
Commit: |
|
||||||||||||||||||
Diff: |
Revision 2 (+3876 -1693) |
5428 provide fts(), reallocarray(), and strtonum()
Review Request #398 — Created March 11, 2017 and submitted
Information | |
---|---|
yuripv | |
illumos-gate | |
master | |
5428 | |
5fda943... | |
Reviewers | |
general | |
Provide several bsd compat functions and header:
- sys/cdefs.h: for now only containing__BEGIN_DECLS
and__END_DECLS
-- dropped for the moment
- fts family: similar to ftw(3C), but a bit more sophisticated
- reallocarray(): similar to realloc(3C), but working on arrays
- strtonum(): a safer alternative to atoi(3C) and strtol(3C) families
for the moment:
- build
- new mandoc version
Change Summary:
fix lint for fts
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+3936 -1755) |
-
-
usr/src/cmd/mdb/common/mdb/mdb_string.h (Diff revision 3) Hmm, it looks like this was never part of the actual external mdb api at least. Though it's a bit unfortunate, I guess there isn't really a great option here.
-
usr/src/head/fts.h (Diff revision 3) Please use the correct illumos header guard, no trailing '_' character.
-
usr/src/head/fts.h (Diff revision 3) I'd recommend keeping this to be like a standard illumos prototype, where all of this is included in the extern "C" bit, not just the functions.
-
usr/src/lib/libc/amd64/Makefile (Diff revision 3) Why create a new directory? Can't we just put them in port/gen?
-
usr/src/man/man3c/fts.3c (Diff revision 3) Just saying safe here actually isn't useful. From my read of the implementation, only one thread should be calling operations on a single instance of an FTS structure at any time. It's worth calling this out. I'd strongly recommend that you write something like the locking section in libavl for this.
-
-
Change Summary:
changes requested by Robert (except for fts.3c update)
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 4 (+3935 -1772) |
Summary: |
|
||||
---|---|---|---|---|---|
Bugs: |
|
Change Summary:
add locking section as described by Robert.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 5 (+3969 -1772) |
Change Summary:
lib/libc/Makefile.targ modifications no longer needed
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 6 (+3964 -1772) |
Change Summary:
just rebase
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 7 (+3964 -1772) |
Change Summary:
stdlib -> gen
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 8 (+3964 -1772) |