6899 coverity problems in localedef

Review Request #386 — Created March 1, 2017 and submitted

yuripv
illumos-gate
master
6899
5b82061...
general
gdamore

6899 coverity problems in localedef

  • fix issues described in #6899
  • fix another bit flag check issue in ctype.c (line 355)
  • add several coverity fixes from FreeBSD (f3bbb3cf24ede85da9181aa9b767c804ff8789fe)
  • handle failures from realloc()
  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
igork
  1. Ship It!
  2. 
      
tsoome
  1. 
      
  2. usr/src/cmd/localedef/localedef.c (Diff revision 1)
     
     

    "Upon successful completion, fclose() returns 0. Otherwise, it returns EOF and sets errno to indicate the error."

    I think it would be correct to use EOF here.

    1. +1 also it could be (fclose(f) != 0)

    2. Not something I introduced, but will fix regardless.

  3. 
      
yuripv
tsoome
  1. Ship It!
  2. 
      
vgusev
  1. Ship It!
  2. 
      
yuripv
Review request changed

Status: Closed (submitted)

Loading...