Please turn it on in your browser preferences.
for specific sites, we recommend the
Review Request #371 -
Created Feb. 19, 2017 and submitted
Feb. 28, 2017, 7:23 a.m.
7895: boot1.efi: multiple fixes from FreeBSD
Why is this check not needed?
The boot_modules is statically built list of modules without NULL entry, so the loop is running over nitems(boot_modules). The list and NUM_BOOT_MODULES are set at the beginning of the file.
Shouldn't this be declared as uintmax_t instead?
The GPT partitioning is defined to use uint64_t values (already in specification), so there is no reason to hide behind uintmax_t, and instead we better keep explicit type to remind us about the data size and type.
Then why not to use PRIu64 instead of %ju/%zu for DPRINTF()?
To keep as close to fbsd as possible. The patch is originating from fbsd, in it only the off_t was changed by me; for completeness we actually should change rest of the off_t as well, but those bits are all over the source and implementing the full scale change now would overcomplicate this change, so I left that (and the corresponding push back to upstream) for later time.