7892 loader.efi: Add defines needed to export SMBIOS serial numbers

Review Request #369 — Created Feb. 19, 2017 and submitted

tsoome
illumos-gate
7892
2b674a4...
general
7892 loader.efi: Add defines needed to export SMBIOS serial numbers


jblachly
  1. Looks good. I read the standard:
    http://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.6.1.pdf
    page 21:

    "Although RFC 4122 recommends network byte order for all fields, the PC industry (including the ACPI, UEFI, and
    Microsoft specifications) has consistently used little-endian byte encoding for the first three fields: time_low,
    time_mid, time_hi_and_version. The same encoding, also known as wire format, should also be used for the
    SMBIOS representation of the UUID."

    1. There's an interesting complication here. Historically libsmbios has been keeping the backwards compatible big endian format. While the SMBIOS version 2.6.1 has specified that, it was not initially specified at all, which leaves a lot of folks in a bit of a pickle if the system uuid changes. I'm not sure if the fact that the loader and the system will report things differently is going to be a problem or not.
    2. the bios version does build with this setup, so in that sense its nothing new. but also since in loader interface it serves just informational purpose, there is no direct harm.

  2. 
      
rm
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...