7889 loader.efi: efipart IO optimization

Review Request #367 — Created Feb. 19, 2017 and submitted

tsoome
illumos-gate
7889
c8cdd4c...
general
7889 loader.efi: efipart IO optimization


  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
marcel
  1. Ship It!
  2. Here you can use off instead of blk * 512.

  3. Here you can use off instead of blk * 512.
  4. Shouldn't this say opposite? Something like: the I/O is not a multiple of the block size of the media.

    1. Yes. Side note, original comment came from freebsd. Should have said what you suggested or succinctly "The IO size is not a multiple of block size".

    2. Actually this whole patch is from freebsd;) but you are right there, the comment wording should be reversed really:D

  5. 
      
jblachly
  1. Ship It!
  2. 
      
tsoome
jbk
  1. Ship It!
  2. 
      
marcel
  1. Ship It!
  2. 
      
jblachly
  1. Looks great - Hope you backport fixes (off for blk * 512 and comment logic reveral) to FreeBSD so we stay in sync!

    1. That is the plan, bit it needs to wait a bit as fbsd already has rewritten efipart.c (by me;) and this and few other small issues just need to wait a bit...

  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...