7875 libcurses: multiple misleading-indentation errors

Review Request #363 — Created Feb. 15, 2017 and submitted

tsoome
illumos-gate
7875
2d1b49e...
general
7875 libcurses: multiple misleading-indentation errors


  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
tsoome
marcel
  1. 
      
  2. usr/src/lib/libcurses/screen/termcap.c (Diff revision 1)
     
     

    This file should not be here.

    1. yes, it is generated and I did miss the fact. removing.

  3. 
      
tsoome
marcel
  1. Ship It!
  2. usr/src/lib/libcurses/screen/termcap.ed (Diff revision 3)
     
     
    I would instead remove this line and unindent the while compound.
  3. usr/src/lib/libcurses/screen/tparm.c (Diff revision 3)
     
     

    onrow is not referenced in a case setjmp() returns nonzero. Seems like a compiler bug.

    1. Yep, but also do not want to start inserting "random" suppressions.

  4. usr/src/lib/libcurses/screen/wnoutref.c (Diff revision 3)
     
     

    s/lo+1/lo + 1/ ?

  5. 
      
gwr
  1. Is there anything in these changes that would affect functionality?
    If not, I'd just turn off the error. This is legacy code...

  2. 
      
tsoome
marcel
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...