7883 snoop(1m) should print locktype for NFSv4 LOCKT operation

Review Request #341 - Created Jan. 30, 2017 and submitted

Information
Marcel Telka
illumos-gate
master
7883
d0d1e21...
Reviewers
general
webrev: http://cr.illumos.org/~webrev/marcel/il-7883-snoop-LOCKT-locktype/
git pull git://github.com/mtelka/illumos-gate.git il-7883-snoop-LOCKT-locktype

The snoop(1m) does not print the locktype for NFSv4 LOCKT operation.
Without the fix:

 19 21:10:42.17156   10.0.100.3 -> 10.0.100.2   NFS C 4 (lock_test   ) PUTFH FH=BB3E LOCKT R=1:1
 20 21:10:42.17192   10.0.100.2 -> 10.0.100.3   NFS R 4 (lock_test   ) NFS4ERR_DENIED PUTFH NFS4_OK LOCKT NFS4ERR_DENIED WR 0 10 LO=10B6
 37 21:10:48.50094   10.0.100.3 -> 10.0.100.2   NFS C 4 (lock_test   ) PUTFH FH=BB3E LOCKT R=1:1
 38 21:10:48.50115   10.0.100.2 -> 10.0.100.3   NFS R 4 (lock_test   ) NFS4ERR_DENIED PUTFH NFS4_OK LOCKT NFS4ERR_DENIED WR 0 10 LO=10B6
 62 21:11:9.53662   10.0.100.3 -> 10.0.100.2   NFS C 4 (lock        ) PUTFH FH=BB3E LOCK WR 1:1 LSQ=10 LST=14BE:6
 64 21:11:9.59972   10.0.100.2 -> 10.0.100.3   NFS R 4 (lock        ) NFS4ERR_DENIED PUTFH NFS4_OK LOCK NFS4ERR_DENIED WR 0 10 LO=10B6
 81 21:11:18.41698   10.0.100.3 -> 10.0.100.2   NFS C 4 (unlock      ) PUTFH FH=BB3E LOCKU R=1:1 LSQ=11 LST=14BE:6
 82 21:11:18.41720   10.0.100.2 -> 10.0.100.3   NFS R 4 (unlock      ) NFS4_OK PUTFH NFS4_OK LOCKU NFS4_OK LST=14BE:7

With the fix:

 19 21:10:42.17156   10.0.100.3 -> 10.0.100.2   NFS C 4 (lock_test   ) PUTFH FH=BB3E LOCKT RD 1:1
 20 21:10:42.17192   10.0.100.2 -> 10.0.100.3   NFS R 4 (lock_test   ) NFS4ERR_DENIED PUTFH NFS4_OK LOCKT NFS4ERR_DENIED WR 0:10 LO=10B6
 37 21:10:48.50094   10.0.100.3 -> 10.0.100.2   NFS C 4 (lock_test   ) PUTFH FH=BB3E LOCKT WR 1:1
 38 21:10:48.50115   10.0.100.2 -> 10.0.100.3   NFS R 4 (lock_test   ) NFS4ERR_DENIED PUTFH NFS4_OK LOCKT NFS4ERR_DENIED WR 0:10 LO=10B6
 62 21:11:9.53662   10.0.100.3 -> 10.0.100.2   NFS C 4 (lock        ) PUTFH FH=BB3E LOCK WR 1:1 LSQ=10 LST=14BE:6
 64 21:11:9.59972   10.0.100.2 -> 10.0.100.3   NFS R 4 (lock        ) NFS4ERR_DENIED PUTFH NFS4_OK LOCK NFS4ERR_DENIED WR 0:10 LO=10B6
 81 21:11:18.41698   10.0.100.3 -> 10.0.100.2   NFS C 4 (unlock      ) PUTFH FH=BB3E LOCKU 1:1 LSQ=11 LST=14BE:6
 82 21:11:18.41720   10.0.100.2 -> 10.0.100.3   NFS R 4 (unlock      ) NFS4_OK PUTFH NFS4_OK LOCKU NFS4_OK LST=14BE:7
Marcel Telka
Marcel Telka
Marcel Telka
Toomas Soome
Vitaliy Gusev
Gordon Ross
Marcel Telka
Review request changed

Status: Closed (submitted)

Change Summary:

commit 2d8dae53e7585d2412a48eceb751cbfaea048241
Author:     Marcel Telka <marcel@telka.sk>
AuthorDate: Thu Feb 16 18:15:45 2017 +0100
Commit:     Dan McDonald <danmcd@omniti.com>
CommitDate: Fri Feb 17 13:31:33 2017 -0500

    7883 snoop(1m) should print locktype for NFSv4 LOCKT operation
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Vitaliy Gusev <gusev.vitaliy@icloud.com>
    Reviewed by: Gordon Ross <Gordon.W.Ross@gmail.com>
    Approved by: Dan McDonald <danmcd@omniti.com>

:100644 100644 107020c... 70b95a5... M	usr/src/cmd/cmd-inet/usr.sbin/snoop/snoop_nfs4.c
Loading...