7770 uts: move font sources to uts/common/font

Review Request #324 — Created Jan. 14, 2017 and submitted

tsoome
illumos-gate
7770
f6c17ec...
general

7770 uts: move font sources to uts/common/font

Build, install boot.

The font data is built in the platform kernel for x86, so it is available to use from modules.

clean build with lint.

  • 0
  • 0
  • 5
  • 0
  • 5
Description From Last Updated
yuripv
  1. Make it usr/src/uts/common/fonts, and you can list me as reviewer. It's not really a module to be in usr/src/uts/common/io.

  2. 
      
tsoome
tsoome
tsoome
tsoome
rm
  1. 
      
  2. usr/src/uts/common/font/font.c (Diff revision 2)
     
     
    It looks like a large chunk (if not most) of this was copied from tem_safe.c. If that's the case, we need to honor the existing copyright there, here.
    1. Yes, indeed, all the font related code was moved out of the tem_safe.c, so we can re-use it later in early boot framebuffer console support.

  3. usr/src/uts/common/sys/font.h (Diff revision 2)
     
     
    'this constant is depending...' -> 'this constant depends on the data in the bdf file. If more entries are added to the bdf files, then this number must be increased.
  4. 
      
tsoome
rm
  1. Ship It!
  2. 
      
yuripv
  1. 
      
  2. usr/src/uts/common/font/font.c (Diff revision 3)
     
     

    s/to/for/

  3. usr/src/uts/common/font/font.c (Diff revision 3)
     
     
  4. usr/src/uts/common/io/tem_safe.c (Diff revision 3)
     
     

    Is this indentation OK for cstyle?

    1. apparently yes, this construct seems to fool it - as soon as I moved the first argument behind '(', pbchk did complain. but I think it is good idea to fix it anyhow... we are going to touch those bits later anyhow;)

  5. 
      
tsoome
yuripv
  1. Ship It!
  2. 
      
rm
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

otis
  1. Ship It!
  2. 
      
Loading...