7715 loader binaries causes wsdiff false positives

Review Request #312 — Created Jan. 3, 2017 and submitted

tsoome
illumos-gate
7715
313, 314
757cc5e...
general
7715 loader binaries causes wsdiff false positives


  • 0
  • 0
  • 1
  • 2
  • 3
Description From Last Updated
tsoome
igork
  1. 
      
  2. usr/src/boot/sys/boot/common/newvers.sh (Diff revision 2)
     
     

    how is hard update build to use version from -DBOOTPROG_VERSION=\"$(VERSION)\"
    or something like that?
    it will be easy pass predevided version in Makefile if need update it

    1. The loader version is to identify the loader itself, in current tree the bios variant, "soon" also the efi variant - which has slightly different ID. If you do not change the code, there is no reason to change the versioning as its purpose is to identify the loader. The branding is done by other means anyhow (brand text and logo).

    2. Same as below. I'll drop this issue for now for the same reason.

  3. 
      
yuripv
  1. 
      
  2. usr/src/boot/sys/boot/common/newvers.sh (Diff revision 2)
     
     

    Do we need this newvers.sh magic at all? May be create a simple vers.c file containing what we need if it's going to be static?

    1. Probably good idea anyhow, kept it right now still, so I was able to verify this step of update.

    2. After considering, I think I would rather keep newvers.sh for now anyhow. Replacing it would mean the alternate method for setting up the info would be needed, and I do not really see any benefit from dropping this method for something else. Probaly there are better ways, but I have no brilliant ideas about it and lets keep the change simple and small. We can always return to the newvers.sh later.

  3. 
      
gwr
  1. Is there really any need for any of that version stuff?
    After all, we have "mcs -p ..."

    1. tsoome@beastie:/code/illumos-gate$ mcs -p /boot/gptzfsboot
      /boot/gptzfsboot: mcs: invalid file type
      tsoome@beastie:/code/illumos-gate$ mcs -p /boot/zfsloader
      /boot/zfsloader: mcs: invalid file type
      tsoome@beastie:/code/illumos-gate$ mcs -p /boot/loader64.efi
      /boot/loader64.efi: mcs: invalid file type

      tsoome@beastie:/code/illumos-gate$ file /boot/zfsloader
      /boot/zfsloader: VAX demand load format a.out object file
      tsoome@beastie:/code/illumos-gate$ file /boot/gptzfsboot
      /boot/gptzfsboot: data
      tsoome@beastie:/code/illumos-gate$ file /boot/zfsloader
      /boot/zfsloader: VAX demand load format a.out object file
      tsoome@beastie:/code/illumos-gate$ file /boot/loader64.efi
      /boot/loader64.efi: DOS executable (EXE)

      not really helpful. Of course the version info is just informational, but over the time, this information will get useful from time to time (assuming it is managed).

    2. Or version info from packaging? Is that not sufficient?

    3. see https://www.illumos.org/rb/r/313/ it is using pre-set version string in usr/src/boot/Makefile.version, can be updated something better later.

  2. 
      
tsoome
hans
  1. Ship It!
  2. 
      
domag02
  1. 
      
  2. usr/src/boot/sys/boot/ofw/common/main.c (Diff revision 3)
     
     
    Mistyped variabe name.
  3. 
      
tsoome
gwr
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...