7681 uts: nfs_dlboot fall back to use rootpath from dhcp

Review Request #300 — Created Dec. 20, 2016 and submitted

tsoome
illumos-gate
7681
f063a2a...
general

7681 uts: nfs_dlboot fall back to use rootpath from dhcp

The traditional solaris behavior is to fetch root path, server name etc from DHCP vendor extensions. However, it is not always easy or even possible to set vendor extensions, so we can also have fall back to use standard dhcp root path option (17). Sure, we still also do have an alternative to pass the data to kernel by properties (server-ip, server-name, server-path), but using properties would require a) knowing about them, b) additional effort.

However, there is an little catch, the option 17 does not describe what exactly is root path, so we do check serverip:/path and set both server_ip and path if needed.

nfs boot.

tsoome
tsoome
xenol
  1. Ship It!
  2. 
      
daleg
  1. 
      
  2. usr/src/uts/common/fs/nfs/nfs_dlinet.c (Diff revision 2)
     
     

    cmn_err() appends a newline itself since this is CE_NOTE. It does not do this when it is of type CE_CONT

    1. ok, I did "borrow" this and the debug message from section strigth above, so removing the \n from original as well.

  3. usr/src/uts/common/fs/nfs/nfs_dlinet.c (Diff revision 2)
     
     

    "server ip" should be "server_ip" since that is the property being evaluated?

    1. well, neither is really wrong I think. I think withouth the underscore, this message will blend better with other debug messages.

  4. 
      
tsoome
daleg
  1. Ship It!
  2. 
      
xenol
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...