7677 kmdb: intel system console value can not be screen

Review Request #298 — Created Dec. 19, 2016 and submitted

tsoome
illumos-gate
7677
eee56e7...
general
7677 kmdb: intel system console value can not be screen

boot -k to enable kmdb;

verify the terminal type in kmdb (::term will print your current terminal, which is different if you are using mdb -k):

> mdb::print struct mdb m_promif | ::print struct kmdb_promif
{
    pif_oterm = 0xfffffffffbd82298 "sun-color"
  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
tsoome
yuripv
  1. 
      
  2. This makes the comment somewhat redundant. How about the following?

    The property "output-device" is based on either "output-device" or "console" properties from actual system, and needs to come from out property cache, so we can't use the official promif one.

    1. It still does feel somewhat odd, I did rewrite this comment another way around - first explaining where the value is set and then stating we need to use cache there.

  3. 
      
tsoome
yuripv
  1. Ship It!
  2. 
      
tsoome
xenol
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...