7677 kmdb: intel system console value can not be screen

Review Request #298 — Created Dec. 19, 2016 and submitted Jan. 10, 2017, 10:32 p.m.

Information
Owner:	tsoome
Repository:	illumos-gate
Branch:
Bugs:	7677
Depends On:
Commit:	eee56e7...
Reviewers
Groups:	general
People:

Description

7677 kmdb: intel system console value can not be screen

Testing Done

boot -k to enable kmdb;
verify the terminal type in kmdb (::term will print your current terminal, which is different if you are using mdb -k):

> mdb::print struct mdb m_promif | ::print struct kmdb_promif
{
    pif_oterm = 0xfffffffffbd82298 "sun-color"

Issues

0
0
1
0
All Issues: 1

Description	From	Last Updated
This makes the comment somewhat redundant. How about the following? The property "output-device" is based on either "output-device" or "console" ...	yuripv	Jan. 5, 2017, 1:31 p.m.

Testing Done:

		boot -k to enable kmdb;

		verify the terminal type in kmdb (::term will print your current terminal, which is different if you are using mdb -k):



		> mdb::print struct mdb m_promif \| ::print struct kmdb_promif
		{
		pif_oterm = 0xfffffffffbd82298 "sun-color"
-
-		And now the arrow keys should also work:)

usr/src/cmd/mdb/intel/kmdb/kmdb_promif_isadep.c (Diff revision 1)

Show all issues

This makes the comment somewhat redundant. How about the following?

The property "output-device" is based on either "output-device" or "console" properties from actual system, and needs to come from out property cache, so we can't use the official promif one.

tsoome Jan. 5, 2017, 9:01 a.m.

It still does feel somewhat odd, I did rewrite this comment another way around - first explaining where the value is set and then stating we need to use cache there.