3772 consider raising default descriptor soft limit
Review Request #292 — Created Dec. 11, 2016 and submitted
| Information | |
|---|---|
| richlowe | |
| illumos-gate | |
| 3772 | |
| 835e938... | |
| Reviewers | |
| general | |
3772 consider raising default descriptor soft limit
Simple benchmark of a non-blocking
select(3C)to excercise the important path in various cases (the important path for performance being the one in which the poll returns immediately).Running locally for a short while. I would appreciate further exposure and benchmarking.
rm
Change Summary:
Add test case
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+346 -514) |
-
In general this seems to look reasonable. Only a small nit on the test, but I think this all make sense.
-
usr/src/test/libc-tests/tests/select/select_test.c (Diff revision 2) Just replace this with arc4random_uniform(3) and get rid of the srandom() call?
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+344 -514) |
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 4 (+772 -867) |
-
I have a few minor comments on the markup rewriting, otherwise this looks generally good.
-
usr/src/man/man3c/select.3c (Diff revision 4) Conventionally we do this as a series of lines per argument type. So this generally should look like:
.Ft void .Fo avl_add .Fa "avl_tree_t *tree" .Fa "void *node" .Fc
So,
.Ftfirst for return type,.Fofor function name, then one.Fafor each argument, with both the type and name. -
-
-
usr/src/man/man3c/select.3c (Diff revision 4) In general, Er is used for error constants ala EPERM. For lack of anything better, I sometimes just use a .Sy 1 if I'm trying to emphasize the return value or flags value.
-
usr/src/man/man3c/select.3c (Diff revision 4) In general, Er is used for error constants ala EPERM. For lack of anything better, I sometimes just use a .Sy 0 if I'm trying to emphasize the return value or flags value.
-
-
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 5 (+798 -869) |
