3772 consider raising default descriptor soft limit

Review Request #292 — Created Dec. 11, 2016 and submitted

richlowe
illumos-gate
3772
835e938...
general
3772 consider raising default descriptor soft limit

Simple benchmark of a non-blocking select(3C) to excercise the important path in various cases (the important path for performance being the one in which the poll returns immediately).

Running locally for a short while. I would appreciate further exposure and benchmarking.

  • 0
  • 0
  • 8
  • 0
  • 8
Description From Last Updated
igork
  1. Ship It!
  2. 
      
richlowe
rm
  1. In general this seems to look reasonable. Only a small nit on the test, but I think this all make sense.
  2. Just replace this with arc4random_uniform(3) and get rid of the srandom() call?
  3. 
      
richlowe
rm
  1. I think this looks good, thanks for putting this together Rich.

  2. 
      
richlowe
otis
  1. Ship It!
  2. 
      
rm
  1. I have a few minor comments on the markup rewriting, otherwise this looks generally good.

  2. usr/src/man/man3c/select.3c (Diff revision 4)
     
     

    Conventionally we do this as a series of lines per argument type. So this generally should look like:

    .Ft void
    .Fo avl_add
    .Fa "avl_tree_t *tree"
    .Fa "void *node"
    .Fc
    

    So, .Ft first for return type, .Fo for function name, then one .Fa for each argument, with both the type and name.

  3. usr/src/man/man3c/select.3c (Diff revision 4)
     
     
    Capital 3C?
  4. usr/src/man/man3c/select.3c (Diff revision 4)
     
     
    Why the trailing \?
  5. usr/src/man/man3c/select.3c (Diff revision 4)
     
     
    In general, Er is used for error constants ala EPERM. For lack of anything better, I sometimes just use a .Sy 1 if I'm trying to emphasize the return value or flags value.
  6. usr/src/man/man3c/select.3c (Diff revision 4)
     
     
    In general, Er is used for error constants ala EPERM. For lack of anything better, I sometimes just use a .Sy 0 if I'm trying to emphasize the return value or flags value.
  7. usr/src/man/man3c/select.3c (Diff revision 4)
     
     
    errnos should use Er, not Dv.
  8. usr/src/man/man3c/select.3c (Diff revision 4)
     
     
    Capital 3C?
  9. 
      
richlowe
rm
  1. Ship It!
  2. 
      
kmays
  1. Ship It!
  2. 
      
richlowe
Review request changed

Status: Closed (submitted)

Loading...