7593 lsdev device name section headers should be printed by dv_print callback.

Review Request #270 — Created Nov. 18, 2016 and submitted

tsoome
illumos-gate
7593
0e89a31...
general
7593 lsdev device name section headers should be printed by dv_print callback.

loader lsdev command should not output headers for non-existing devices.

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
yuripv
  1. 
      
  2. usr/src/boot/sys/boot/common/dev_net.c (Diff revision 1)
     
     

    Wonder why you aren't using sizeof (line) here (and below), so if you change its size, you don't have to update everything.

    1. Ouch, thanks, this code does not need line at all and I did miss that change. Fixed and updated the RB.

  3. 
      
tsoome
tsoome
tsoome
rm
  1. Otherwise, seems like everything else is properly calling pager_output, including the disk_print() recursive logic.

  2. This is missing the call to pager_output().
  3. 
      
tsoome
rm
  1. Ship It!
  2. 
      
yuripv
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...