13356 syslog(3c) should not open syslog_door without LOG_CONS

Review Request #2580 — Created Dec. 8, 2020 and submitted

Information
marcel
illumos-gate
master
13356
7af7163...
Reviewers
general 
This defers call to syslogd_ok() in syslog(3C) after the check for LOG_CONS
flag to save few expensive calls like open(2), door_info(3C), door_call(3C),
and close(2) when not needed.

Work by David Hanisch.
See https://www.illumos.org/issues/13356#note-1
  • 0
  • 0
  • 0
  • 1
  • 1
Description From Last Updated
rm
rm 
  1. 
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      usr/src/lib/libc/port/gen/syslog.c
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Is it worth adding a comment to explain why we order the checks this way?
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      I do not think it is needed, but if you suggests some wording I can add it there.  Thanks.
      
 
      

      2. 


 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




marcel




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
commit 986778a303c760bb2204efc52ea9eba748546342
Author:     David Hanisch <titanic@dh-werder.de>
AuthorDate: Tue Dec 8 15:27:10 2020 +0100
Commit:     Robert Mustacchi <rm@fingolfin.org>
CommitDate: Thu Jan 21 06:29:31 2021 -0800

    13356 syslog(3c) should not open syslog_door without LOG_CONS
    Reviewed by: Marcel Telka <marcel@telka.sk>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

:100644 100644 9c4e7b9443 99c2be2030 M	usr/src/lib/libc/port/gen/syslog.c





 


 










  

 









     

    

   

  

  

   
   Loading...