12747 sigsetjmp should allow for 8 byte aligned buffer on amd64

Review Request #2565 - Created May 24, 2020 and updated

Information
Vitaliy Gusev
illumos-gate
master
12747
e0b0db8...
Reviewers
general

This solution fixes libc. No need recompilation of existing binaries.

Before patch:

$ /usr/bin/amd64/mdb
> Segmentation Fault

After patch:

$ LD_PRELOAD=/tmp/libc.so.1 /usr/bin/amd64/mdb 
> ::version
mdb 1.1 (DEBUG)

Issues

  • 0
  • 6
  • 1
  • 7
Description From Last Updated
Joshua Clulow
Vitaliy Gusev
Vitaliy Gusev
Robert Mustacchi
Vitaliy Gusev
Robert Mustacchi
Vitaliy Gusev
Vitaliy Gusev
Vitaliy Gusev
Vitaliy Gusev
Robert Mustacchi
Joshua Clulow
Vitaliy Gusev
Review request changed

Change Summary:

Changes:

  • Correct commenst according to Joshua's notes.

  • Fix csctyle complaint about old code
    "C style: usr/src/lib/libc/amd64/threads/machdep.c: 70:
    continuation line should be indented by 4 spaces"

  • Fix extra space before sizeof

Commit:

-dce4ab1d98e42997ef582cbc9dfcde74fac8d2f0
+e0b0db831838f8f5a676323057e5348d90472bb7

Diff:

Revision 8 (+26 -7)

Show changes

Joshua Clulow

Thank you for the changes! This looks good to me.

Robert Mustacchi
Ship It!
Loading...