yuripv
-
-
usr/src/cmd/boot/bootadm/bootadm_loader.c (Diff revision 1) Synopsis says 'key=value', so apparently we must have the value, and should error here if val is NULL.
-
usr/src/cmd/boot/bootadm/bootadm_loader.c (Diff revision 1) It looks like this path is affected as well, fix both?
12729 bootadm set-menu timeout crashes without timeout value
Review Request #2554 — Created May 13, 2020 and submitted
| Information | |
|---|---|
| alhazred | |
| illumos-gate | |
| master | |
| https://www.illumos.org/issues/12729 | |
| Reviewers | |
| general | |
| tsoome | |
12729 bootadm set-menu timeout crashes without timeout value
Without fix:
root@omniosce:~# bootadm set-menu timeout
Segmentation Fault (core dumped)With fix:
root@omniosce:~# ./bootadm set-menu timeout
bootadm: missing timeout value
root@omniosce:~# ./bootadm set-menu timeout=
bootadm: invalid timeout:
root@omniosce:~# ./bootadm set-menu timeout=10
root@omniosce:~#
-
Ship it!
Note: There is a standard function to handle these type of suboptions, and it's called getsubopt(3C).