4537 flowadm show-flowprop shows possible values of properties incorrectly

Review Request #2525 - Created March 1, 2020 and updated

Information
Peter Tribble
illumos-gate
4537
Reviewers
general

See issue - flowadm shows current values rather than possible values in the POSSIBLE column.

Revised version shows the possible values correctly

Issues

  • 3
  • 1
  • 2
  • 6
Description From Last Updated
Is there a reason to duplicate this? If we're inside of libdladm, why not just make the definition non-static and ... Robert Mustacchi Robert Mustacchi
Please don't use strcpy here. We have no way of guarding that vd_name can't exceed *prop_val. Can you please use ... Robert Mustacchi Robert Mustacchi
Same bit on strcpy as above. Robert Mustacchi Robert Mustacchi
Andy Fiddaman
Peter Tribble
Review request changed
Toomas Soome
Ship It!
Robert Mustacchi

   
usr/src/lib/libdladm/common/flowprop.c (Diff revision 2)
 
 
Is there a reason to duplicate this? If we're inside of libdladm, why not just make the definition non-static and share it?
usr/src/lib/libdladm/common/flowprop.c (Diff revision 2)
 
 
Please don't use strcpy here. We have no way of guarding that vd_name can't exceed *prop_val. Can you please use strlcpy and return an error?
usr/src/lib/libdladm/common/flowprop.c (Diff revision 2)
 
 
Same bit on strcpy as above.
Loading...