citrus
-
-
-
usr/src/lib/libdladm/common/flowprop.c (Diff revision 1) strlcpy()here withDLADM_PROP_VAL_MAXas the length argument?
It's probably save to cast to void still - I'm not sure what you'd return if it failed -
usr/src/lib/libdladm/common/flowprop.c (Diff revision 1) You've already done the work to find the right slot in the
prop_table, so just checkpd_temponlydirectly?
4537 flowadm show-flowprop shows possible values of properties incorrectly
Review Request #2525 — Created March 1, 2020 and updated
| Information | |
|---|---|
| ptribble | |
| illumos-gate | |
| 4537 | |
| Reviewers | |
| general | |
See issue - flowadm shows current values rather than possible values in the POSSIBLE column.
Revised version shows the possible values correctly
- 3
- 0
- 1
- 2
- 6
| Description | From | Last Updated |
|---|---|---|
| Is there a reason to duplicate this? If we're inside of libdladm, why not just make the definition non-static and ... |
rm
|
|
| Please don't use strcpy here. We have no way of guarding that vd_name can't exceed *prop_val. Can you please use ... |
rm
|
|
| Same bit on strcpy as above. |
rm
|
-
-
usr/src/lib/libdladm/common/flowprop.c (Diff revision 2) Is there a reason to duplicate this? If we're inside of libdladm, why not just make the definition non-static and share it?
-
usr/src/lib/libdladm/common/flowprop.c (Diff revision 2) Please don't use strcpy here. We have no way of guarding that vd_name can't exceed *prop_val. Can you please use strlcpy and return an error?
-