usr/src/boot/lib/libstand/printf.c (Diff revision 1)

Show all issues

This appears incomplete. It doesn't seem to be handling the logic that the rest of the normal 's' case seems to be. For example, the null check, width, etc. Is that expected or intentional?

1. 

   Toomas Soome Dec. 29, 2016, 12:04 p.m.

   Yep, it is/was very sketchy, I rewrote it to behave same as %s above.

usr/src/boot/sys/boot/common/bootstrap.h (Diff revision 2)

Show all issues

Where does C_WIDEOUT actually get consumed? I see you setting it on the EFI console, but is there something which uses this information?

1. 

   Toomas Soome Dec. 29, 2016, 4:26 p.m.

   Right now it is actually not used. I kept it there to keep the sources in sync, as it is quite painful to dig out the missed bits from all of those commits. They actually do commit a lot and small, so some functionality can get implemented gradually over many (and not necessarily adjacent) commits.

2. 

   Robert Mustacchi Dec. 29, 2016, 4:27 p.m.

   OK, thanks. I just wanted to make sure I wasn't missing anything.

Ship It!

Ship It!