7549 Add support for %S to libstand as well so /boot/loader and friends can use it.

Review Request #252 — Created Nov. 8, 2016 and submitted

tsoome
illumos-gate
7549
a91a459...
general
7549 Add support for %S to libstand as well so /boot/loader and friends can use it.


  • 0
  • 0
  • 1
  • 1
  • 2
Description From Last Updated
rm
  1. 
      
  2. usr/src/boot/lib/libstand/printf.c (Diff revision 1)
     
     
    This appears incomplete. It doesn't seem to be handling the logic that the rest of the normal 's' case seems to be. For example, the null check, width, etc. Is that expected or intentional?
    1. Yep, it is/was very sketchy, I rewrote it to behave same as %s above.

  3. 
      
tsoome
rm
  1. 
      
  2. Where does C_WIDEOUT actually get consumed? I see you setting it on the EFI console, but is there something which uses this information?
    1. Right now it is actually not used. I kept it there to keep the sources in sync, as it is quite painful to dig out the missed bits from all of those commits. They actually do commit a lot and small, so some functionality can get implemented gradually over many (and not necessarily adjacent) commits.

    2. OK, thanks. I just wanted to make sure I wasn't missing anything.

  3. 
      
rm
  1. Ship It!
  2. 
      
xenol
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...