7549 Add support for %S to libstand as well so /boot/loader and friends can use it.

Review Request #252 — Created Nov. 8, 2016 and submitted Jan. 10, 2017, 10:06 p.m.

Information
Owner:	tsoome
Repository:	illumos-gate
Branch:
Bugs:	7549
Depends On:
Commit:	a91a459...
Reviewers
Groups:	general
People:

Description

7549 Add support for %S to libstand as well so /boot/loader and friends can use it.

Testing Done

Issues

0
0
1
1
All Issues: 2

Description	From	Last Updated
This appears incomplete. It doesn't seem to be handling the logic that the rest of the normal 's' case seems ...	rm	Dec. 29, 2016, 12:04 p.m.
Where does C_WIDEOUT actually get consumed? I see you setting it on the EFI console, but is there something which ...	rm	Dec. 29, 2016, 4:27 p.m.

usr/src/boot/lib/libstand/printf.c (Diff revision 1)

Show all issues

This appears incomplete. It doesn't seem to be handling the logic that the rest of the normal 's' case seems to be. For example, the null check, width, etc. Is that expected or intentional?

tsoome Dec. 29, 2016, 12:04 p.m.

Yep, it is/was very sketchy, I rewrote it to behave same as %s above.

Change Summary:

Merged with https://svnweb.freebsd.org/base?view=revision&revision=r300056. Rewrote libstand printf %S to have the same functionality as %s.

Commit:

-	229dcbdc43e6984c9fe52ad87e1bf86ee29be120
+	a91a459a65ed71492a9e0f9678884ab87217743b

Diff:

Revision 2 (+32 -2)

Show changes

	usr/src/boot/lib/libstand/printf.c
	usr/src/boot/sys/boot/common/bootstrap.h
	usr/src/boot/sys/boot/common/util.c
	usr/src/boot/sys/boot/efi/libefi/efi_console.c

usr/src/boot/sys/boot/common/bootstrap.h (Diff revision 2)

Show all issues

Where does C_WIDEOUT actually get consumed? I see you setting it on the EFI console, but is there something which uses this information?

tsoome Dec. 29, 2016, 4:26 p.m.

Right now it is actually not used. I kept it there to keep the sources in sync, as it is quite painful to dig out the missed bits from all of those commits. They actually do commit a lot and small, so some functionality can get implemented gradually over many (and not necessarily adjacent) commits.

rm Dec. 29, 2016, 4:27 p.m.

OK, thanks. I just wanted to make sure I wasn't missing anything.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

You have a pending review.

Review Board 3.0.18

7549 Add support for %S to libstand as well so /boot/loader and friends can use it.

Change Summary:

Commit:

Diff:

Status: Closed (submitted)