12264 halt: unused label

Review Request #2505 — Created Jan. 29, 2020 and submitted

marcel
illumos-gate
master
12264
5268975...
general
This removes an unused label from halt.c together with -_gcc=-Wno-unused-label
removal from the Makefile.
Nightly passed even without -Wno-unused-label for halt.
mscheler
  1. Ship It!
  2. 
      
tsoome
  1. Ship It!
  2. 
      
ptribble
  1. Ship It!
  2. 
      
domag02
  1. Ship It!
  2. 
      
marcel
Review request changed

Status: Closed (submitted)

Change Summary:

commit 1b2ec6d6cf3fc8870f15f0100929dfde15fb32c6
Author:     Marcel Telka <marcel@telka.sk>
AuthorDate: Wed Jan 29 17:53:09 2020 +0100
Commit:     Dan McDonald <danmcd@joyent.com>
CommitDate: Mon Jan 10 10:53:19 2022 -0500

    12264 halt: unused label
    Reviewed by: Matthias Scheler <mscheler@tintri.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Peter Tribble <peter.tribble@gmail.com>
    Reviewed by: Gergő Mihály Doma <domag02@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

:100644 100644 a515a0a1ef 895698d8fd M  usr/src/cmd/halt/Makefile
:100644 100644 893539611b 52d7314b05 M  usr/src/cmd/halt/halt.c
vgusev
  1. $ git grep no-unused-label|wc -l
    273

    It seems a lot of code in illumos has this problem. Do you have plans to fix them all

  2. 
      
Loading...