12248 libdscp no longer needs to link with libnsl
Review Request #2497 — Created Jan. 24, 2020 and submitted — Latest diff uploaded
| Information | |
|---|---|
| ptribble | |
| illumos-gate | |
| 12248 | |
| Reviewers | |
| general | |
SPARC builds generate the following noise: usr/platform/SUNW,SPARC-Enterprise/lib/fm/fmd/plugins/event-transport.so: unreferenced object=/export/home/ptribble/Illumos/2020-gate/proto/root_sparc/lib/libnsl.so.1; unused dependency of /export/home/ptribble/Illumos/2020-gate/proto/root_sparc/usr/platform/SUNW,SPARC-Enterprise/lib/libdscp.so.1 <remove lib or -zignore?> usr/platform/SUNW,SPARC-Enterprise/lib/libdscp.so.1: unreferenced object=/export/home/ptribble/Illumos/2020-gate/proto/root_sparc/lib/libnsl.so.1; unused dependency of /export/home/ptribble/Illumos/2020-gate/proto/root_sparc/usr/platform/SUNW,SPARC-Enterprise/lib/libdscp.so.1 <remove lib or -zignore?> usr/platform/SUNW,SPARC-Enterprise/sbin/prtdscp: unreferenced object=/export/home/ptribble/Illumos/2020-gate/proto/root_sparc/lib/libnsl.so.1; unused dependency of /export/home/ptribble/Illumos/2020-gate/proto/root_sparc/usr/platform/SUNW,SPARC-Enterprise/lib/libdscp.so.1 <remove lib or -zignore?> This is because libdscp uses the functions inet_ntop and inet_pton, but these moved from libnsl to libc in #9673. Therefore, we no longer need to pull in libnsl.
With the change, build is clean and the noise is gone.
Verified with ldd that the dependency is no longer present and is no longer required.