12215 pyzfs module does not build with python 3.7

Review Request #2492 — Created Jan. 19, 2020 and submitted Jan. 20, 2020, 11:19 p.m.

Description

12215 pyzfs module does not build with python 3.7

Testing Done

Issues

Description	From	Last Updated
I think if you change this line to const char *keystr = PyUnicode_AsUTF8(key); you should be safe with both 3.5 ...	marcel	Jan. 20, 2020, 11:49 a.m.
Isn't it better to make the local variable "const", rather than subvert the attributes of the function? Same below?	pwinder	Jan. 20, 2020, 11:49 a.m.
I think if you change this line to const char *valstr = PyUnicode_AsUTF8(value); you should be safe with both 3.5 ...	marcel	Jan. 20, 2020, 11:49 a.m.

usr/src/lib/pyzfs/common/ioctl.c (Diff revision 1)

Show all issues

I think if you change this line to const char *keystr = PyUnicode_AsUTF8(key); you should be safe with both 3.5 and 3.7.

usr/src/lib/pyzfs/common/ioctl.c (Diff revision 1)

Show all issues

I think if you change this line to const char *valstr = PyUnicode_AsUTF8(value); you should be safe with both 3.5 and 3.7.

usr/src/lib/pyzfs/common/ioctl.c (Diff revision 1)

Show all issues

Isn't it better to make the local variable "const", rather than subvert the attributes of the function?
Same below?

-	c7c6188d071b4dcc5b0873430cb2426b9552ea8f
+	dacd2b508cc48eb238e1cfa44c9f18afbd954499

Ship it!

Ship it!

Ship it!

You have a pending review.