- Download Diff

Summary:

12141 libbe cannot handle vfstab updates in NGZ

Review Request #2477 — Created Dec. 29, 2019 and submitted Jan. 6, 2020, 11:18 a.m.

Information
Owner:	citrus
Repository:	illumos-gate
Branch:	master
Bugs:	12141
Depends On:
Commit:	d5e5671...
Reviewers
Groups:	general
People:

Description

12141 libbe cannot handle vfstab updates in NGZ

Testing Done

See issue for write-up

Issues

0
0
1
0
All Issues: 1

Description	From	Last Updated
Maybe only be_root_container is needed given the following appears above: /* New BE will reside in the same zpool as ...	seeemef@mac.com	Jan. 3, 2020, 8:04 p.m.

The identical code to "Update new BE's vfstab" is also in be_rename() (differing it seems only in the function name in the error message). I'm wondering if the bug affects that operation too.

citrus Dec. 30, 2019, 10:04 a.m.

Yes, same problem, thanks!

be_rename: failed to update new BE's vfstab (test2)

Change Summary:

Also fix beadm rename

Commit:

-	775adfa644b0cf9e664f6cbaf93f9028d338fd44
+	a7b90a128a0132134635fe4d5434da010d5922f8

Diff:

Revision 2 (+53 -6)

Show changes

	usr/src/lib/libbe/common/be_create.c
	usr/src/lib/libbe/common/be_rename.c
	usr/src/lib/libbe/common/be_utils.c
	usr/src/lib/libbe/common/libbe_priv.h

Ship it!

```
Ship It!
```

Commit:

-	a7b90a128a0132134635fe4d5434da010d5922f8
+	c147bdae51e514b69506c95735998d137fbb2777

Diff:

Revision 3 (+53 -6)

Show changes

	usr/src/lib/libbe/common/be_create.c
	usr/src/lib/libbe/common/be_rename.c
	usr/src/lib/libbe/common/be_utils.c
	usr/src/lib/libbe/common/libbe_priv.h

Ship it!

Ship It!

tsoome Dec. 30, 2019, 8:12 p.m.

Actually... something you want to consider is to use be_get_defaults(&be_defaults); and be_defaults.be_deflt_rpool_container :)

usr/src/lib/libbe/common/be_rename.c (Diff revision 3)

Show all issues

Maybe only be_root_container is needed given the following appears above:

/* New BE will reside in the same zpool as orig BE */
bt.nbe_zpool = bt.obe_zpool;

Commit:

-	c147bdae51e514b69506c95735998d137fbb2777
+	d5e5671706d121e653a812ebd37c819bde392825

Diff:

Revision 4 (+54 -6)

Show changes

	usr/src/lib/libbe/common/be_create.c
	usr/src/lib/libbe/common/be_rename.c
	usr/src/lib/libbe/common/be_utils.c
	usr/src/lib/libbe/common/libbe_priv.h

Ship it!

```
LGTM
```

Ship it!

```
Ship It!
```

You have a pending review.

Review Board 3.0.18

12141 libbe cannot handle vfstab updates in NGZ

Change Summary:

Commit:

Diff:

Commit:

Diff:

Commit:

Diff:

Status: Closed (submitted)