12070 sata SSDs attached to sata ports can't trim

Review Request #2472 — Created Dec. 10, 2019 and submitted Dec. 18, 2019, 8:11 p.m.

Information
Owner:	jjelinek
Repository:	illumos-gate
Branch:
Bugs:	12070
Depends On:
Reviewers
Groups:	general
People:

Description

Fix the sata trim detection code to match the spec.

Testing Done

Expand All
Collapse All

Ship it!

Not sure if it would disrupt the code flow to explain why we're checking for the ai_dsm TRIM bit first. The bug report explains this nicely, wasn't sure if it should end up in the (seemingly sparsely-commented) sd code as well. Not a deal-breaker, though.