7526 bzip2 should have way to hide the compression support

Review Request #247 — Created Oct. 31, 2016 and submitted

tsoome
illumos-gate
7526
f96c94c...
general
7526 bzip2 should have way to hide the compression support

Build is clean, no missing symbols reported when LOADER_BZIP2_SUPPORT is defined in build rules.

yuripv
  1. Ship It!
  2. 
      
rm
  1. Can you expand a bit more on why we need to hide these symbols? What does their presence actually cause? What fails?
    1. The size. The BIOS loader binary is placed on low memory (base 0xa000), so it has to fit below upper EBDA and video memory; meaning the practical limit in memory ~500k. So as we do know at least for now that we wont need compression in loader, only decompression, we want to make sure the unneeded functions are not linked in by mistake or error. There is still quite some spare space, but it is possible to blow it up by careless build options and such - I have not done it myself, but it did happen in fbsd.

    2. Thanks for clarifying.
  2. 
      
rm
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...