ptree zone handling is broken
Review Request #2465 — Created Nov. 27, 2019 and submitted
| Information | |
|---|---|
| jbk | |
| illumos-gate | |
| 12037 | |
| Reviewers | |
| general | |
proc_walk(3PROC) skips SSYS processes, so it never descends into children of zsched, preventing -z from working.
Built new binary + libproc, ran new (and pre-11096 binary of ptree), and compared output -- aside from the pid of the ptree processes themselves, no differences were found.
Then ran both pre-11096 + new binary with -z argument of a running zone and compared output. The output was identical
jlevon
rm
-
-
usr/src/man/man3proc/proc_walk.3proc (Diff revision 1) I don't think we should be naming this flag after a deprecated interface (SSYS bit)
PR_WALK_INCLUDE_SYS ?
-
-
usr/src/man/man3proc/proc_walk.3proc (Diff revision 2) This should be more explicit since it disagrees with the heading for the list of flags. I would add a sentence that makes it explicit that this cannot be used on its own. Alternatively, I think it might be better to create a new list of flags that are listed as being combined. In that world it'd be something like: .El The following values may be combined into .Fa flag with a bitwise-inclusive-OR: .Bl -tag -width Dv -indent offset .It Dv PR_WALK_INCLUDE_SYS ... .El The bitwise-inclusive-OR phrase is used elsewhere in the 3proc manuals.