kkantor
-
-
usr/src/uts/common/fs/zfs/sys/range_tree.h (Diff revision 1) It looks like the changes to this struct will break a number of things in mdb. Do you think we should make those changes under this commit, or a follow-on commit?
11971 Reduce loaded range tree memory usage
Review Request #2457 — Created Nov. 18, 2019 and submitted
| Information | |
|---|---|
| jjelinek | |
| illumos-gate | |
| 11971 | |
| Reviewers | |
| general | |
This is a port from OpenZFS of the range tree performance work that Paul Dagnelie of Delphix presented at the recent OpenZFS developers conference.
Change Summary:
Pulled in the relevant mdb changes from the Delphix backport of the range tree work and fixed things up to work with our ZoL port.
Change Summary:
More mdb fixes I missed in the last commit. This fixes the zfs_btree walker.
Diff: |
Revision 3 (+3929 -644)
|
|---|
Change Summary:
This should hopefully be the final set of mdb fixes I found in the Delphix src tree.
Diff: |
Revision 4 (+3968 -655)
|
|---|
-
Looks good to me. I don't think we have to fix the little nits if you don't want to.
-
usr/src/cmd/mdb/common/modules/zfs/zfs.c (Diff revision 4) little thing: the
int ican be in the loop header now. -
usr/src/cmd/mdb/common/modules/zfs/zfs.c (Diff revision 4) There seems to be inconsistent use of %p vs %#lx in this file for printing addresses.
Also, I suppose the use of
%#lxacross this file could be replaced with%#" PRIx64 ". It appears that%#lxis much more common in the mdb source than the more portable alternative, however.
