7864 acpidump: use acpi-root-tab property

Review Request #245 — Created Oct. 23, 2016 and submitted

tsoome
illumos-gate
7864
440a540...
general

7864 acpidump: use acpi-root-tab property

UEFI system; from prtconf -v:
name='acpi-root-tab' type=int64 items=1
value=000000000ef9d000

root@uefi-oi:/home/tsoome# /usr/sbin/acpidump
Could not get ACPI tables, AE_NOT_FOUND

patched acpidump:
root@uefi-oi:/home/tsoome# ./acpidump | head
RSD @ 0x000000000EF9D000
0000: 52 53 44 20 50 54 52 20 12 56 4D 57 41 52 45 02 RSD PTR .VMWARE.
0010: 24 D0 F9 0E 24 00 00 00 60 D0 F9 0E 00 00 00 00 $...$...`.......
0020: A5 00 00 00 ....

RSDT @ 0x000000000EF9D024
0000: 52 53 44 54 3C 00 00 00 01 08 49 4E 54 45 4C 20 RSDT<.....INTEL
0010: 34 34 30 42 58 20 20 20 00 00 04 06 56 4D 57 20 440BX ....VMW
0020: 72 42 32 01 B4 D0 F9 0E A1 B2 FA 0E 15 B3 FA 0E rB2.............
0030: 8F B3 FA 0E CB B3 FA 0E 03 B4 FA 0E ............
root@uefi-oi:/home/tsoome#

  • 0
  • 0
  • 2
  • 0
  • 2
Description From Last Updated
xenol
  1. Ship It!
  2. 
      
tsoome
rm
  1. 
      
  2. Please update this comment.
  3. Do we really need to copy all information or is DINFOPROP sufficient? Though it probably doesn't matter too much.
    1. yes, DINFOPROP is sufficient, replaced.

  4. 
      
tsoome
rm
  1. Aside from a few comment improvements, I think this looks good.
  2. There are some minor typos here. I think it may be better phrased as:
    
    If the system is not using a BIOS, and ACPI information was passed to the system from the boot loader, then the RSDP is recorded in the "acpi-root-tab" property.
    
    The code here is derived from AcpiFindRootPointer, except that we will try the "acpi-root-tab" property first. If the property does not exist or we do not find the root, then we scan the EBDA. Finally, we will search the BIOS and copy the table if found.
  3. 
      
tsoome
jjelinek
  1. Ship It!
  2. 
      
tsoome
otis
  1. Ship It!
  2. 
      
rm
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...