Minor fixes in clnt_cots.c (11954, 11955)

Review Request #2449 — Created Nov. 11, 2019 and submitted

Information
marcel
illumos-gate
master
11954, 11955
ccacac4...
Reviewers
general 
This fixes a potential memory leak in connmgr_get() and simplifies code around
kmem_free(9f) in clnt_cots.c in some cases.
I ran debug build of NFS client with this change integrated for several days to
make sure there is no panic.  Everything worked as expected.
vgusev
vgusev 
  1. Are you going to fix clnt_clts and clnt_rmdma as well ?
    1. Currently, I do not plan to do so.
  2. 
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




citrus




   

   







  

 



 

  


   

   

    
 
citrus


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




marcel




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
commit f67d64d998ff666158cc5231b7e80c11c3e922e0
Author:     Marcel Telka <marcel@telka.sk>
AuthorDate: Mon Nov 11 07:59:33 2019 +0100
Commit:     Dan McDonald <danmcd@joyent.com>
CommitDate: Thu Nov 14 11:19:43 2019 -0500

    11954 rpcmod: Possible memory leak in connmgr_get()
    11955 clnt_cots: kmem_free(NULL, 0) is legal
    Reviewed by: Vitaliy Gusev <gusev.vitaliy@icloud.com>
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Approved by: Dan McDonald <danmcd@joyent.com>

:100644 100644 0c75b6dca6 d15710d467 M	usr/src/uts/common/rpc/clnt_cots.c





 


 










  

 









     

    

   

  

  

   
   Loading...