smatch sometimes flags problems with ipmp_snap_take()
Review Request #2448 - Created Nov. 9, 2019 and submitted
| Information | |
|---|---|
| Jason King | |
| illumos-gate | |
| 11951 | |
| Reviewers | |
| general | |
Sometimes smatch complains about a double free of 'snap' in ipmp_snap_take()
Built with fix. Built with unrelated code changes (#11946) that were also able to reliably trigger smatch warnings.
Ship It!
Ship It!
Ship It!
Review request changed
Change Summary:
I tried the change with some additional pending changes, and ended up not being able to find a combination of changes that silenced smatch in all of them, so instead I've had to resort to just disabling the specific check on the file. That does seem to have worked with all the changes that had failed previously.
Diff: |
Revision 3 (+5 -1) |
|---|
Yea, I like this one better:)
Yes, they look like a false positives to me.
Is it worth opening an issue for this against smatch?
Ship It!
Ship It!