Change Summary:
whitespace, lint and a few cstyle cleanups.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+622 -350) |
Review Request #2447 — Created Nov. 9, 2019 and submitted
Information | |
---|---|
citrus | |
illumos-gate | |
master | |
11949 | |
c366f8c... | |
Reviewers | |
general | |
rm |
11949 make -C caches wrong directory contents
Running the tests introduced with this change shows all passes (versus mostly failures before):
PASS make -C a/ from empty directory PASS make -C a/ from non-empty directory PASS makeflags -C a/ from empty directory PASS makeflags -C a/ from non-empty directory PASS make -C a/a from empty directory PASS make -C a/a from non-empty directory PASS makeflags -C a/a from empty directory PASS makeflags -C a/a from non-empty directory PASS make -C a/b from empty directory PASS make -C a/b from non-empty directory PASS makeflags -C a/b from empty directory PASS makeflags -C a/b from non-empty directory PASS make -C a/c from empty directory PASS make -C a/c from non-empty directory PASS makeflags -C a/c from empty directory PASS makeflags -C a/c from non-empty directory PASS make -C -C from empty directory PASS make -C -C from non-empty directory PASS makeflags -C -C from empty directory PASS makeflags -C -C from non-empty directory PASS make -C -C relative from empty directory PASS make -C error PASS make -C error (output) PASS MAKEFLAGS=-C error PASS MAKEFLAGS=-C error (output) PASS make -C <noexist> PASS make -C <noexist> (output) PASS MAKEFLAGS=-C <noexist> PASS MAKEFLAGS=-C <noexist> (output)
whitespace, lint and a few cstyle cleanups.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+622 -350) |
usr/src/test/util-tests/tests/make/make_test.ksh (Diff revision 2) |
---|
illumos shell style prefers [[ for tests. Only mentioning it here.
usr/src/test/util-tests/tests/make/make_test.ksh (Diff revision 2) |
---|
Is this just for a user who wants to get more output?
Updates following review by Robert Mustacchi
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+622 -350) |
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 4 (+618 -350) |
usr/src/test/util-tests/tests/make/make_test.ksh (Diff revisions 2 - 4) |
---|
If we can't create the test directory, shouldn't we stop execution of this function?
usr/src/test/util-tests/tests/make/make_test.ksh (Diff revisions 2 - 4) |
---|
If we can't create the test directory, shouldn't we stop execution of this function?
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 5 (+626 -350) |