11938 loader.efi: HARDDRIVE_DEVICE_PATH may have subpaths

Review Request #2443 — Created Nov. 6, 2019 and submitted Nov. 22, 2019, 7:11 p.m.

Information
Owner:	tsoome
Repository:	illumos-gate
Branch:
Bugs:	11938
Depends On:
Commit:	53a6c3e...
Reviewers
Groups:	general
People:

Description

11938 loader.efi: HARDDRIVE_DEVICE_PATH may have subpaths

Testing Done

Issues

0
0
2
0
All Issues: 2

Description	From	Last Updated
Can the comment explain why we need to do this? It's not really clear to me.	rm	Nov. 19, 2019, 5:48 p.m.
Is there a reason this is a separate if statement? Seems like the if case should be the else above ...	rm	Nov. 19, 2019, 5:48 p.m.

Change Summary:

actually create sub-partition list.

Commit:

-	8d4868f8cf67b7214d5f1572f426e6d543483d78
+	e8e893c062665f550abe95fceaf957368936421e

Diff:

Revision 2 (+56 -13)

Show changes

	usr/src/boot/Makefile.version
	usr/src/boot/sys/boot/efi/libefi/efipart.c

Change Summary:

missed variable rename and unused one.

Commit:

-	e8e893c062665f550abe95fceaf957368936421e
+	f751bbc0a4dd1d36566923969bf276bc70c933db

Diff:

Revision 3 (+55 -12)

Show changes

usr/src/boot/sys/boot/efi/libefi/efipart.c

usr/src/boot/sys/boot/efi/libefi/efipart.c (Diff revision 3)

Show all issues

Can the comment explain why we need to do this? It's not really clear to me.

tsoome Nov. 19, 2019, 5:48 p.m.
```
I hope the update is making it better:)
```

usr/src/boot/sys/boot/efi/libefi/efipart.c (Diff revision 3)

Show all issues

Is there a reason this is a separate if statement? Seems like the if case should be the else above and the else case here should be part of the original if as both are dealing with the same condition.