Docs
Support

JavaScript is turned off

Review Board requires JavaScript in order to function. Please turn it on in your browser preferences.

Firefox users: if you prefer to turn on JavaScript only for specific sites, we recommend the NoScript extension.

Reviews
Diff

- Download Diff

Summary:

11935 loader: fix memory corruption bug in vdev_read

Review Request #2441 — Created Nov. 6, 2019 and submitted Nov. 14, 2019, 6:21 p.m.

Information
Owner:	tsoome
Repository:	illumos-gate
Branch:
Bugs:	11935
Depends On:
Commit:	711d596...
Reviewers
Groups:	general
People:

Description

https://svnweb.freebsd.org/base?view=revision&revision=r344226
https://svnweb.freebsd.org/base?view=revision&revision=r344234
https://svnweb.freebsd.org/base?view=revision&revision=r348471

The bug occurred when a bounce buffer was used and the requested read
size was greater than the size of the bounce buffer.  This commit also
rewrites the read logic so that it is easier to systematically verify
all alignment and size cases.

Testing Done

Issues

0
0
1
0
All Issues: 1

Description	From	Last Updated
Left over debug code?	mscheler	Nov. 6, 2019, 2:06 p.m.

Commit:

-	0f819d84b9b94b4a812934cf4c862613a0971cfc
+	afc48941ab65e68d0c8e33d54874c6c520ba1331

Diff:

Revision 2 (+82 -31)

	usr/src/boot/Makefile.version
	usr/src/boot/lib/libstand/zfs/zfs.c

usr/src/boot/lib/libstand/zfs/zfs.c (Diff revision 2)
Show all issues
```
Left over debug code?
```
1. tsoome Nov. 6, 2019, 2:06 p.m.
  Yep.

Commit:

-	afc48941ab65e68d0c8e33d54874c6c520ba1331
+	80433313dacacdceb376463f8b652d4ff5ad7920

Diff:

Revision 3 (+81 -31)

	usr/src/boot/Makefile.version
	usr/src/boot/lib/libstand/zfs/zfs.c

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Change Summary:

rebase on master.

Commit:

-	80433313dacacdceb376463f8b652d4ff5ad7920
+	711d596330c4287e655aac0ba02a364ffd31df02

Diff:

Revision 4 (+81 -31)

	usr/src/boot/Makefile.version
	usr/src/boot/lib/libstand/zfs/zfs.c

Status: Closed (submitted)

Loading...