11908 usr/src/cmd/sgs links against libraries outside the proto area

Review Request #2430 - Created Nov. 1, 2019 and updated

Information
Andrew Stormont
illumos-gate
11908
Reviewers
general

The avoid linking against libraries outside the proto area:

usr/src/cmd/sgs/librtld_db/demo needs to depend on
- usr/src/cmd/sgs/librtld_db/i386 (for librtld_db.so)
- usr/src/cmd/sgs/lex (for libl.so)
- usr/src/cmd/sgs/yacc (for liby.so)

usr/src/lib/libdwarf needs to depend on
- usr/src/cmd/sgs/libelf

Full build.

Issues

  • 2
  • 0
  • 0
  • 2
Description From Last Updated
Does extrasubdirs never have a conditional 64-bit component? Robert Mustacchi Robert Mustacchi
Why is this a FIXME? Is there something that's inherently wrong about the dependency? How did this previously work? Should ... Robert Mustacchi Robert Mustacchi
Andrew Stormont
Review request changed

Description:

   

The avoid linking against libraries outside the proto area:

   
~  

usr/src/cmd/sgs/librtld_db/data needs to depend on

  ~

usr/src/cmd/sgs/librtld_db/demo needs to depend on

    - usr/src/cmd/sgs/librtld_db/i386 (for librtld_db.so)
    - usr/src/cmd/sgs/lex (for libl.so)
    - usr/src/cmd/sgs/yacc (for liby.so)

   
   

usr/src/lib/libdwarf needs to depend on

    - usr/src/cmd/sgs/libelf

Robert Mustacchi

   
usr/src/cmd/sgs/Makefile.sub (Diff revision 1)
 
 
 
Does extrasubdirs never have a conditional 64-bit component?
  1. No. Not as far as I could tell.

usr/src/lib/Makefile (Diff revision 1)
 
 
 
Why is this a FIXME? Is there something that's inherently wrong about the dependency?

How did this previously work? Should the sgs Makefiles themselves be trying to ensure this? If someone did a dmake install in cmd/sgs, would we get the right thing? If not, maybe this is the wrong place to encode it?
  1. I added the FIXME because I think it's crap that we unconditionally build the demo program. If we only built the libraries and this stage we wouldn't need to worry about those dependencies.

  2. I think it's important that we do always build them, othewise we won't know they're broken. Which was a problem for quite some time with them. This of course, may not be the best place to do them. But I think part of Rich's goals were to make sure that they were always built.

Loading...