7492 incremental build fails in $SRC/cmd/localedef

Review Request #243 — Created Oct. 22, 2016 and submitted

gwr
illumos-gate
7492
general

mkdir failure

incremental build

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
igork
  1. 
      
  2. usr/src/cmd/localedef/Makefile (Diff revision 1)
     
     

    i'd like to use 'mkdir -p'

    1. Why? The directory is always just "native" (one level)

    2. I agree with Igor. If -p is passed no error will be produced if the directory alreay exists.

    3. I didn't remember that -p had that side-effect. OK.

    4. You're both wrong, you want $(INS.dir).

    5. Sorry, I only just noticed that RB swallowed my response to this. To clarify, the reason you want to be using $(INS.dir) instead, is uniformity with every other directory we create (it uses install under the hood, and is also safe for the same reason as -p).

    6. You sure about that? I see a bunch of -@mkdir -p in the gate too.
      I'd have guessed INS.dir would be for things that we're actually
      installing (in the proto area) which is not what's going on here.

    7. If we're already sloppy about it, do either. I just remember having being asked to do it that way before :)

  3. 
      
yuripv
  1. Just to be sure, could you describe the problem?

    1. Added that to the bug. (the "native" directory may already exist, i.e. in an incremental build)

  2. 
      
gwr
igork
  1. Ship It!
  2. 
      
andy_js
  1. Ship It!
  2. 
      
gwr
Review request changed

Status: Closed (submitted)

Loading...