11881 loader: zfs_fmtdev can crash when pool discovery did fail and we have no spa

Review Request #2420 — Created Oct. 26, 2019 and submitted

tsoome
illumos-gate
11881
e5d361e...
general
FreeBSD commit: https://svnweb.freebsd.org/changeset/base/353757

When zfs probe did fail and no spa was created, but zfs_fmtdev() is called,
we will crash while dereferencing spa (NULL pointer dereference).


  • 0
  • 0
  • 0
  • 1
  • 1
Description From Last Updated
seeemef@mac.com
  1. Ship It!
  2. 
      
citrus
  1. Ship It!
  2. 
      
kkantor
  1. Looks good! I say 'ship it' if we don't need to worry about conflicting BOOT_VERSIONs.

  2. usr/src/boot/Makefile.version (Diff revision 1)
     
     

    Does this conflict with the 'loader: zio_checksum_verify should check byteswap' change to this line? Do you suggest we integrate this first followed by the zfs boot changes?

    1. Yes it does. The version itself is the mechanism to identify we got the update, when we do have conflict in version number, we can just fix it. It is not meant to be mechanism to enforce patch order, but to tell installboot that it must perform the update.

      But yes, I do have RTI build in progress right now (I had thermal paste dried out and had to wait over weekend to get new tube:D).

  3. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...