Description: |
|
---|
11864 SMB2 CREATE should reject absolute paths
Review Request #2409 — Created Oct. 23, 2019 and discarded
Information | |
---|---|
andy_js | |
illumos-gate | |
11864 | |
Reviewers | |
general | |
gdamore, gwr |
The SMB2 documentation says we should reject CREATE requests with absolute paths but we don't currently do that:
"If the file name length is greater than zero and the first character is a path separator character, the server MUST fail the request with STATUS_INVALID_PARAMETER."
This impacts the following WPTS test cases:
CreateCloseTestCaseS249
CreateCloseTestCaseS122
CreateCloseTestCaseS443
CreateCloseTestCaseS418
CreateCloseTestCaseS406
CreateCloseTestCaseS379
CreateCloseTestCaseS367
CreateCloseTestCaseS346
CreateCloseTestCaseS331
CreateCloseTestCaseS285
CreateCloseTestCaseS273
Prior to applying the fix the above test cases fail. With the fix applied they now pass.
-
-
usr/src/uts/common/fs/smbsrv/smb2_create.c (Diff revision 1) Should this change too then? And if so, to what? an empty string?
Does the common code DTRT when the passed string is something like "" or "."?