11817 Clean up C++ code in libnisdb

Review Request #2394 — Created Oct. 15, 2019 and discarded

andy_js
illumos-gate
11817
general

There are a bunch of unused variables, some missing parentheses and some places where variables may have been used initialised.

Full build.

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
vgusev
  1. 
      
  2. usr/src/lib/libnisdb/db_dictionary.cc (Diff revision 1)
     
     

    It looks like logic is changed here. For instance, consider
    Original code:

    1. get_next_hashsize(16001)
      line 397: newsize is 0
      line 398: newsize is set to 32002

    1. get_next_hashsize(32002)
      line 397: newsize is 0
      line 398: newsize is set ot 64004

    Changed code:
    1. is the same.

    1. get_next_hashsize(32002)
      line 391: newsize is 16001.
      line 394: return 16001
  3. 
      
andy_js
andy_js
vgusev
  1. Ship It!
  2. 
      
andy_js
andy_js
andy_js
Review request changed

Status: Discarded

Loading...