11806 SMB server sends malformed responses on error

Review Request #2392 - Created Oct. 11, 2019 and submitted

Information
Andrew Stormont
illumos-gate
11806
Reviewers
general
gwr

The SMB2 dispatch code can emit partially constructed responses if a request handler returns SDRC_ERROR. This is easily observed over WireShark when running the WPTS (Windows Protocol Test Suites). One particular test case shows this very clearly: the InvalidCreateRequestStructureSize test found in the CreateClose section.

Ran WPTS and observed the traffic with WireShark. After applying the fix the SMB server no longer sends malformed responses.

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Vitaliy Gusev
Gordon Ross
Andrew Stormont
Gordon Ross
Garrett D'Amore
Andrew Stormont
Review request changed

Status: Closed (submitted)

Loading...