11798 apix: cast between incompatible function types

Reviews
Diff

- Download Diff

Information
Submitter:	Toomas Soome
Repository:	illumos-gate
Branch:
Bugs:	11798
Depends On:
Commit:	49c793a...
Reviewers
Groups:	general
People:

Description

../../i86pc/io/apix/apix.c:623:25: error: cast between incompatible function types from 'void (*)(char *, struct regs *)' to 'uint_t (*)(char *, char *)' {aka 'unsigned int (*)(char *, char *)'} [-Werror=cast-function-type]
  if (!psm_add_nmintr(0, (avfunc) apic_nmi_intr,
                         ^

../../i86pc/io/hpet_acpi.c:353:33: error: cast between incompatible function types from 'uint_t (*)(char *)' {aka 'unsigned int (*)(char *)'} to 'uint_t (*)(char *, char *)' {aka 'unsigned int (*)(char *, char *)'} [-Werror=cast-function-type]
  rem_avintr(NULL, CBE_HIGH_PIL, (avfunc)&hpet_isr,
                                 ^
../../i86pc/io/hpet_acpi.c: In function 'hpet_install_interrupt_handler':
../../i86pc/io/hpet_acpi.c:617:42: error: cast between incompatible function types from 'uint_t (*)(char *)' {aka 'unsigned int (*)(char *)'} to 'uint_t (*)(char *, char *)' {aka 'unsigned int (*)(char *, char *)'} [-Werror=cast-function-type]
  retval = add_avintr(NULL, CBE_HIGH_PIL, (avfunc)func, "HPET Timer",
                                          ^
cc1: all warnings being treated as errors

Testing Done

Issues

0
4
0
All Issues: 4

Description	From	Last Updated
arg should be 'avfunc'	John Levon	Oct. 11, 2019, 8:21 a.m.
first arg should be __unused too?	John Levon	Oct. 11, 2019, 8:22 a.m.
mark both as __unused, remove :807?	John Levon	Oct. 11, 2019, 8:31 a.m.
I'm not sure this is right	John Levon	Oct. 11, 2019, 8:46 a.m.