11795 ksslf: cast between incompatible function types

Review Request #2381 — Created Oct. 9, 2019 and submitted Oct. 11, 2019, 6:16 p.m.

Information
Owner:	tsoome
Repository:	illumos-gate
Branch:
Bugs:	11795
Depends On:
Commit:	2e48c3b...
Reviewers
Groups:	general
People:

Description

../../common/inet/kssl/ksslrec.c:88:33: error: cast between incompatible function types from 'void (*)(SHA1_CTX *, const void *, size_t)' {aka 'void (*)(struct <anonymous> *, const void *, long unsigned int)'} to 'void (*)(void *, uchar_t *, uint32_t)' {aka 'void (*)(void *, unsigned char *, unsigned int)'} [-Werror=cast-function-type]
      (hashinit_func_t)SHA1Init, (hashupdate_func_t)SHA1Update,
                                 ^
cc1: all warnings being treated as errors

Testing Done

Issues

0
0
1
0
All Issues: 1

Description	From	Last Updated
I think this comment would be clearer if it actually referred to the argument issues. How about something like: 'Wrapper ...	rm	Oct. 10, 2019, 6:21 a.m.

usr/src/uts/common/inet/kssl/ksslrec.c (Diff revision 1)

Show all issues

I think this comment would be clearer if it actually referred to the argument issues. How about something like:

'Wrapper for SHA1Update to translate arguments. We need this because the KSSL hash update function expects the size argument to be a uint32_t, but SHA1Update uses a size_t.'