11791 idm: this statement may fall through

Review Request #2376 - Created Oct. 9, 2019 and updated

Information
Toomas Soome
illumos-gate
11791
1351a1b...
Reviewers
general
../../common/io/idm/idm_conn_sm.c:1464:3: error: this statement may fall through [-Werror=implicit-fallthrough=]
   switch (ic->ic_state) {
   ^~~~~~
../../common/io/idm/idm_conn_sm.c:1481:2: note: here
  case ISCSI_OP_SCSI_CMD:
  ^~~~
../../common/io/idm/idm_conn_sm.c:1491:3: error: this statement may fall through [-Werror=implicit-fallthrough=]
   switch (ic->ic_state) {
   ^~~~~~
../../common/io/idm/idm_conn_sm.c:1507:2: note: here
  case ISCSI_OP_LOGOUT_CMD:
  ^~~~
../../common/io/idm/idm_conn_sm.c:1511:3: error: this statement may fall through [-Werror=implicit-fallthrough=]
   switch (ic->ic_state) {
   ^~~~~~
../../common/io/idm/idm_conn_sm.c:1527:2: note: here
  case ISCSI_OP_LOGIN_CMD:
  ^~~~
cc1: all warnings being treated as errors

  
Andy Fiddaman
Ship It!
Garrett D'Amore

This results in functional differences (the old code was actually clearly buggy, so fixing this is a good thing.) This implies we'll need to somehow test this prior to RTI.

  1. Yes, I already have one iscsi related change in my testing queue...

Loading...