Summary:

6382 Possible memory leak in load_heuristics()

Review Request #237 — Created Oct. 16, 2016 and updated Dec. 31, 2016, 4:35 p.m.

Description

6382 Possible memory leak in load_heuristics()

My first contribution to illumos.

Testing Done

Needs somebody to build-test it.

Issues

Description	From	Last Updated
you can move this free to line 276, just before free(hp). free() is nop if the argument is NULL, and ...	tsoome	Dec. 31, 2016, 4:36 p.m.

Updated contact e-mail.

		6382 Possible memory leak in load_heuristics()

~		My first contribution to illumos.
	~	My first contribution to illumos.
-		I have an another design without gotos.

~		Not tested (currently).
	~	Needs somebody to build-test it.

As mentioned by jbk on IRC:

-malloc replaced by calloc.

-Missed free(hp->prog).

usr/src/lib/libdiskmgt/common/inuse_fs.c (Diff revision 3)

Show all issues

you can move this free to line 276, just before free(hp). free() is nop if the argument is NULL, and calloc does give you zeroed memory.

free(hp->prog) moved.

Added Files:

free(hp->prog) moved.

You have a pending review.