11774 SMB2 does not support reauthentication

Review Request #2366 - Created Oct. 3, 2019 and updated

Information
Andrew Stormont
illumos-gate
11774
Reviewers
general

SMB2 clients should be allowed to send SESSION SETUP again to reauthenticate, but when a client tries to reauthenticate now it fails with STATUS_USER_SESSION_DELETED.

Prior to this change the BVT_SessionMgmt_Reauthentication test included in the Windows Protocol Test Suites was failing. With the change applied it now passes.

Issues

  • 1
  • 0
  • 0
  • 1
Description From Last Updated
Actually, I'm not sure this is sufficient to bring the state of the user object back to "logging on". Have ... Gordon Ross Gordon Ross
Andy Fiddaman
Gordon Ross
Andrew Stormont
Review request changed

Change Summary:

Mention reauthentiation in the comments.

Diff:

Revision 2 (+35 -1)

Show changes

Garrett D'Amore
Ship It!
Gordon Ross

Here too, please don't rush to integration on this change.
I'll explain why with some design notes in the issue.

Gordon Ross

   

Actually, I'm not sure this is sufficient to bring the state of the user object back to "logging on".
Have you checked whethere the subsequent smb_user_logon call leaks stuff? It might, becuase smb_user_logon is not expecting the user details (names, cred etc) to be there with the current set of state transitions. Also, see my notes in the issue:
https://www.illumos.org/issues/11774

Loading...