11766 SMB2 stops responding after LOGOFF
Review Request #2361 - Created Oct. 1, 2019 and discarded
The Windows Protocol Test Suite wants to do a series of SESSION SETUP and LOGOFF requests to validate behaviour but our SMB2 stack stops responding after it recieves a LOGOFF request.
A full pass of the Windows Protocol Test Suite. The number of session tests that passes is up from 42 to 83 with 2 failures. Fixes for the 2 failures will be addressed separately.
|Don't need smb_rwx_rwenter/smb_rwx_rwexit According to smb_rwx_cvbcast description, and since setting state to SMB_SESSION_STATE_SHUTDOWN was removed, smb_rwx_rwenter/smb_rwx_rwexit usage can be dropped ...||Vitaliy Gusev|
This looks wrong or at least incomplete.
smb_rwx_cvbcast()'s purpose is to wakeup a thread that has called smb_rwx_cvwait(). And the only caller of the latter function checks explicitly for SMB_SESSION_STATE_SHUTDOWN.
It seems to be that this wait and notification mechanism has now lost its purpose and should be removed.