11766 SMB2 stops responding after LOGOFF

Review Request #2361 — Created Oct. 1, 2019 and discarded Oct. 11, 2019, 7:13 a.m.

Information
Owner:	andy_js
Repository:	illumos-gate
Branch:
Bugs:	11766
Depends On:
Reviewers
Groups:	general
People:

Description

The Windows Protocol Test Suite wants to do a series of SESSION SETUP and LOGOFF requests to validate behaviour but our SMB2 stack stops responding after it recieves a LOGOFF request.

Testing Done

A full pass of the Windows Protocol Test Suite. The number of session tests that passes is up from 42 to 83 with 2 failures. Fixes for the 2 failures will be addressed separately.

Issues

1
0
0
1
All Issues: 2

Description	From	Last Updated
Don't need smb_rwx_rwenter/smb_rwx_rwexit According to smb_rwx_cvbcast description, and since setting state to SMB_SESSION_STATE_SHUTDOWN was removed, smb_rwx_rwenter/smb_rwx_rwexit usage can be dropped ...	vgusev	Oct. 8, 2019, 6:01 p.m.
This looks wrong or at least incomplete. smb_rwx_cvbcast()'s purpose is to wakeup a thread that has called smb_rwx_cvwait(). And the ...	mscheler	Oct. 7, 2019, 3:43 p.m.

Testing Done:

~		A full pass of the Windows Protocol Test Suite. The number of session tests that passes is up from 43 to 82 with 2 failures. Fixes for the 2 failures will be addressed separately.
	~	A full pass of the Windows Protocol Test Suite. The number of session tests that passes is up from 42 to 83 with 2 failures. Fixes for the 2 failures will be addressed separately.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

usr/src/uts/common/fs/smbsrv/smb_user.c (Diff revision 1)

Show all issues

This looks wrong or at least incomplete.
smb_rwx_cvbcast()'s purpose is to wakeup a thread that has called smb_rwx_cvwait(). And the only caller of the latter function checks explicitly for SMB_SESSION_STATE_SHUTDOWN.
It seems to be that this wait and notification mechanism has now lost its purpose and should be removed.

andy_js Oct. 7, 2019, 3:22 p.m.

That code is not just checking the state, it's also checking to see that the number of users is 0.

mscheler Oct. 7, 2019, 3:43 p.m.
```
Fair enough
```

Fix it!

usr/src/uts/common/fs/smbsrv/smb_user.c (Diff revision 1)

Show all issues

Don't need smb_rwx_rwenter/smb_rwx_rwexit

According to smb_rwx_cvbcast description, and since setting state to SMB_SESSION_STATE_SHUTDOWN was removed, smb_rwx_rwenter/smb_rwx_rwexit usage can be dropped here.

Would you mind just holding off on this one a little longer?
I have a more complete fix coming that covers this problem too.
Assign the issue to me if you like.

You have a pending review.

Review Board 3.0.18

11766 SMB2 stops responding after LOGOFF

Testing Done:

Status: Discarded