11766 SMB2 stops responding after LOGOFF

Review Request #2361 — Created Oct. 1, 2019 and discarded

andy_js
illumos-gate
11766
general

The Windows Protocol Test Suite wants to do a series of SESSION SETUP and LOGOFF requests to validate behaviour but our SMB2 stack stops responding after it recieves a LOGOFF request.

A full pass of the Windows Protocol Test Suite. The number of session tests that passes is up from 42 to 83 with 2 failures. Fixes for the 2 failures will be addressed separately.

  • 1
  • 0
  • 0
  • 1
  • 2
Description From Last Updated
Don't need smb_rwx_rwenter/smb_rwx_rwexit According to smb_rwx_cvbcast description, and since setting state to SMB_SESSION_STATE_SHUTDOWN was removed, smb_rwx_rwenter/smb_rwx_rwexit usage can be dropped ... vgusev vgusev
andy_js
citrus
  1. Ship It!
  2. 
      
tsoome
  1. Ship It!
  2. 
      
mscheler
  1. 
      
  2. usr/src/uts/common/fs/smbsrv/smb_user.c (Diff revision 1)
     
     

    This looks wrong or at least incomplete.

    smb_rwx_cvbcast()'s purpose is to wakeup a thread that has called smb_rwx_cvwait(). And the only caller of the latter function checks explicitly for SMB_SESSION_STATE_SHUTDOWN.

    It seems to be that this wait and notification mechanism has now lost its purpose and should be removed.

    1. That code is not just checking the state, it's also checking to see that the number of users is 0.

    2. Fair enough
  3. 
      
vgusev
  1. 
      
  2. usr/src/uts/common/fs/smbsrv/smb_user.c (Diff revision 1)
     
     

    Don't need smb_rwx_rwenter/smb_rwx_rwexit

    According to smb_rwx_cvbcast description, and since setting state to SMB_SESSION_STATE_SHUTDOWN was removed, smb_rwx_rwenter/smb_rwx_rwexit usage can be dropped here.

  3. 
      
gwr
  1. Would you mind just holding off on this one a little longer?
    I have a more complete fix coming that covers this problem too.
    Assign the issue to me if you like.

  2. 
      
andy_js
Review request changed

Status: Discarded

Loading...