7469 loader should use acpica provided by OS

Review Request #236 — Created Oct. 14, 2016 and submitted

tsoome
illumos-gate
7469
372d9b2...
general
7469 loader should use acpica provided by OS

build, install, boot.
in loader ok prompt, verify the acpi.* variables are there and have reasonable values.

rm
  1. In general this looks good, but one thing I'm trying to figure out is where in the Makefiles we end up specifying to use the freebsd include file as in the mailing list it talked about how we don't use the same acsolaris.h that we're currently using.
    1. ah, the acfreebsd.h is used in usr/src/boot/sys/boot/i386/libi386/biosacpi.c in current code, as acpica framework needs basic platform definitions and acfreebsd.h is built to serve both the kernel (which we do not care about in loader) and standalone build. As the loader is entirely standalone and as it is build for bsd, we can not have our /usr/include tree to get in... acsolaris.h for another hand, has served us well in kernel build, but I think it will be wise to build acillumos.h for our needs - to have support for kernel/userland/standalone in reasonable way. But thats again something for future work.

    2. Ah okay, that clarifies things, thanks.

  2. 
      
yuripv
  1. Ship It!
  2. 
      
rm
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...