Ship It!

Ship It!

Ship It!

usr/src/cmd/mdb/common/mdb/mdb_module.c (Diff revision 1)

Maybe it would be a good idea to have some kind of compile-time assert to check MDB_API_VERSION hasn't changed?

1. 

   Toomas Soome Oct. 2, 2019, 11:04 a.m.

   But what if it was legitimate change?

2. 

   Andrew Stormont Oct. 2, 2019, 11:10 a.m.

   Then update the code and the assert together.

Ship It!

usr/src/cmd/mdb/common/mdb/mdb_debug.h (Diff revision 2)

Show all issues

This may "open a can of worms".

The macros in sys/debug.h use

assfail() or assfail3().

Are those "the right thing" in mdb?

Even if so, I'm concerned about what else might be affected by this change.
Also, the CTASSERT macro is not really needed for this fix.

(see my next comment).

1. 

   Toomas Soome Oct. 9, 2019, 7:35 p.m.

   oh right, I have to admit, I totally did forgot about #error. thanks.

usr/src/cmd/mdb/common/mdb/mdb_module.c (Diff revision 2)

You really don't need CTASSERT in debug.h for this.

You could just as easily do:

#if MDB_API_VERSION != 5
#error "need attention here"
#endif


"Keep it simple" :)

Ship It!

Looks good.  Thanks.

Ship It!