11749 nfs4_end_*_seqid_sync() should call cv_signal()
Review Request #2349 — Created Sept. 26, 2019 and submitted
| Information | |
|---|---|
| marcel | |
| illumos-gate | |
| master | |
| 11749 | |
| d352612... | |
| Reviewers | |
| general | |
This replaces cv_broadcast() call by cv_signal() call in both nfs4_end_open_seqid_sync() and nfs4_end_lock_seqid_sync() functions to get better and predictable performance for file handling operations at NFSv4 client.
We tested both cv_broadcast() and cv_signal() calls in nfs4_end_open_seqid_sync() with non-trivial load at NFSv4 client and we found that the time spent in nfs4_start_open_seqid_sync() is noticeable lower with cv_signal() than with cv_broadcast(). More details about the test conducted could be found at https://www.illumos.org/issues/11749#note-3
Summary: |
|
||||
|---|---|---|---|---|---|
Commit: |
|
||||
Diff: |
Revision 2 (+3 -3) |
Description: |
|
|||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+3 -3) |
Status: Closed (submitted)
Change Summary:
commit f2211ffec9a7ac3c1efc6de9347072f816f10a60
Author: Marcel Telka <marcel@telka.sk>
AuthorDate: Thu Sep 26 15:30:29 2019 +0200
Commit: Dan McDonald <danmcd@joyent.com>
CommitDate: Fri Sep 27 12:40:05 2019 -0400
11749 nfs4_end_*_seqid_sync() should call cv_signal()
Reviewed by: Jan Schlien <illumos-bugs@jan-o-sch.net>
Reviewed by: Toomas Soome <tsoome@me.com>
Reviewed by: Arne Jansen <arne@die-jansens.de>
Reviewed by: Garrett D'Amore <garrett@damore.org>
Approved by: Dan McDonald <danmcd@joyent.com>
:100644 100644 8b082582d6 914dfe6bdd M usr/src/uts/common/fs/nfs/nfs4_client_state.c