11747 zpool iostat -v no longer shows titles for log sections

Review Request #2347 — Created Sept. 24, 2019 and submitted Sept. 25, 2019, 9:33 a.m.

Information
Owner:	citrus
Repository:	illumos-gate
Branch:	master
Bugs:	11747
Depends On:
Commit:	6491943...
Reviewers
Groups:	general
People:	jjelinek

Description

11747 zpool iostat -v no longer shows titles for log sections

Testing Done

Before:

% pfexec zpool iostat -v test
               capacity     operations    bandwidth
pool        alloc   free   read  write   read  write
----------  -----  -----  -----  -----  -----  -----
test         624K   895M      0      0  1.86K  8.46K
  c6t1d0     624K   895M      0      0  1.85K  7.29K
  c3t0d0        0  7.50G      0      0     11  1.17K
----------  -----  -----  -----  -----  -----  -----

After:

% pfexec ./zpool iostat -v test
               capacity     operations    bandwidth
pool        alloc   free   read  write   read  write
----------  -----  -----  -----  -----  -----  -----
test         624K   895M      0      0  1.86K  8.47K
  c6t1d0     624K   895M      0      0  1.85K  7.30K
logs            -      -      -      -      -      -
  c3t0d0        0  7.50G      0      0     11  1.17K
----------  -----  -----  -----  -----  -----  -----

People:

+	jjelinek

Testing Done:

	+	Before:
	+
	+
	+
	+	% pfexec zpool iostat -v test
	+	capacity operations bandwidth
	+	pool alloc free read write read write
	+	---------- ----- ----- ----- ----- ----- -----
	+	test 624K 895M 0 0 1.86K 8.46K
	+	c6t1d0 624K 895M 0 0 1.85K 7.29K
	+	c3t0d0 0 7.50G 0 0 11 1.17K
	+	---------- ----- ----- ----- ----- ----- -----
	+
	+
	+
	+	After:
	+
	+
	+
	+	% pfexec ./zpool iostat -v test
	+	capacity operations bandwidth
	+	pool alloc free read write read write
	+	---------- ----- ----- ----- ----- ----- -----
	+	test 624K 895M 0 0 1.86K 8.47K
	+	c6t1d0 624K 895M 0 0 1.85K 7.30K
	+	logs - - - - - -
	+	c3t0d0 0 7.50G 0 0 11 1.17K
	+	---------- ----- ----- ----- ----- ----- -----

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

usr/src/cmd/zpool/zpool_main.c (Diff revision 1)

I don't see a scripted option (-H?) for iostat subcommand - is this check really needed here?

citrus Sept. 24, 2019, 9:42 p.m.

No, not required, but I kept as much in common with what's in ZoL as I could.
Hopefully we can pull over the rest of the changes to zpool iostat in the near future.

jjelinek Sept. 25, 2019, 2:13 a.m.

I'm already working on porting that, but it will be a while before I'm done, so I appreciate keeping good alignment.

Ship it!

This looks like the best analogue to the current ZoL implementation, thanks for fixing it.

You have a pending review.

Review Board 3.0.18

11747 zpool iostat -v no longer shows titles for log sections

People:

Testing Done:

Status: Closed (submitted)