- Download Diff

Summary:

11721 bnxe: cast between incompatible function types

Review Request #2325 — Created Sept. 20, 2019 and submitted Oct. 11, 2019, 7:10 a.m.

Information
Owner:	tsoome
Repository:	illumos-gate
Branch:
Bugs:	11721
Depends On:
Commit:	2aec221...
Reviewers
Groups:	general
People:

Description

../../common/io/bnxe/577xx/common/bnxe_clc.c:12430:21: error: cast between incompatible function types from 'void (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)' to 'u8 (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)' {aka 'unsigned char (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)'} [-Werror=cast-function-type]
  /*.config_init = */(config_init_t)elink_xgxs_config_init,
                     ^
../../common/io/bnxe/577xx/common/bnxe_clc.c:12431:21: error: cast between incompatible function types from 'elink_status_t (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)' {aka 'enum elink_status (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)'} to 'u8 (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)' {aka 'unsigned char (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)'} [-Werror=cast-function-type]
  /*.read_status = */(read_status_t)elink_link_settings_status,
                     ^
../../common/io/bnxe/577xx/common/bnxe_clc.c:12469:21: error: cast between incompatible function types from 'void (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)' to 'u8 (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)' {aka 'unsigned char (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)'} [-Werror=cast-function-type]
  /*.config_init = */(config_init_t)elink_xgxs_config_init,
                     ^
../../common/io/bnxe/577xx/common/bnxe_clc.c:12470:21: error: cast between incompatible function types from 'elink_status_t (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)' {aka 'enum elink_status (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)'} to 'u8 (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)' {aka 'unsigned char (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)'} [-Werror=cast-function-type]
  /*.read_status = */(read_status_t)elink_link_settings_status,
                     ^
../../common/io/bnxe/577xx/common/bnxe_clc.c:12509:21: error: cast between incompatible function types from 'void (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)' to 'u8 (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)' {aka 'unsigned char (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)'} [-Werror=cast-function-type]
  /*.config_init = */(config_init_t)elink_warpcore_config_init,
                     ^
../../common/io/bnxe/577xx/common/bnxe_clc.c:12510:21: error: cast between incompatible function types from 'elink_status_t (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)' {aka 'enum elink_status (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)'} to 'u8 (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)' {aka 'unsigned char (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)'} [-Werror=cast-function-type]
  /*.read_status = */(read_status_t)elink_warpcore_read_status,
                     ^
../../common/io/bnxe/577xx/common/bnxe_clc.c:12544:21: error: cast between incompatible function types from 'elink_status_t (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)' {aka 'enum elink_status (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)'} to 'u8 (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)' {aka 'unsigned char (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)'} [-Werror=cast-function-type]
  /*.config_init = */(config_init_t)elink_7101_config_init,
                     ^
../../common/io/bnxe/577xx/common/bnxe_clc.c:12548:22: error: cast between incompatible function types from 'elink_status_t (*)(u32,  u8 *, u16 *)' {aka 'enum elink_status (*)(unsigned int,  unsigned char *, short unsigned int *)'} to 'u8 (*)(u32,  u8 *, u16 *)' {aka 'unsigned char (*)(unsigned int,  unsigned char *, short unsigned int *)'} [-Werror=cast-function-type]
  /*.format_fw_ver= */(format_fw_ver_t)elink_7101_format_ver,
                      ^
../../common/io/bnxe/577xx/common/bnxe_clc.c:12578:21: error: cast between incompatible function types from 'elink_status_t (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)' {aka 'enum elink_status (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)'} to 'u8 (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)' {aka 'unsigned char (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)'} [-Werror=cast-function-type]
  /*.config_init = */(config_init_t)elink_8073_config_init,
                     ^
../../common/io/bnxe/577xx/common/bnxe_clc.c:12582:22: error: cast between incompatible function types from 'elink_status_t (*)(u32,  u8 *, u16 *)' {aka 'enum elink_status (*)(unsigned int,  unsigned char *, short unsigned int *)'} to 'u8 (*)(u32,  u8 *, u16 *)' {aka 'unsigned char (*)(unsigned int,  unsigned char *, short unsigned int *)'} [-Werror=cast-function-type]
  /*.format_fw_ver= */(format_fw_ver_t)elink_format_ver,
                      ^
../../common/io/bnxe/577xx/common/bnxe_clc.c:12609:21: error: cast between incompatible function types from 'elink_status_t (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)' {aka 'enum elink_status (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)'} to 'u8 (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)' {aka 'unsigned char (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)'} [-Werror=cast-function-type]
  /*.config_init = */(config_init_t)elink_8705_config_init,
                     ^
../../common/io/bnxe/577xx/common/bnxe_clc.c:12613:22: error: cast between incompatible function types from 'elink_status_t (*)(u32,  u8 *, u16 *)' {aka 'enum elink_status (*)(unsigned int,  unsigned char *, short unsigned int *)'} to 'u8 (*)(u32,  u8 *, u16 *)' {aka 'unsigned char (*)(unsigned int,  unsigned char *, short unsigned int *)'} [-Werror=cast-function-type]
  /*.format_fw_ver= */(format_fw_ver_t)elink_null_format_ver,
                      ^
../../common/io/bnxe/577xx/common/bnxe_clc.c:12641:21: error: cast between incompatible function types from 'elink_status_t (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)' {aka 'enum elink_status (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)'} to 'u8 (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)' {aka 'unsigned char (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)'} [-Werror=cast-function-type]
  /*.read_status = */(read_status_t)elink_8706_read_status,
                     ^
../../common/io/bnxe/577xx/common/bnxe_clc.c:12644:22: error: cast between incompatible function types from 'elink_status_t (*)(u32,  u8 *, u16 *)' {aka 'enum elink_status (*)(unsigned int,  unsigned char *, short unsigned int *)'} to 'u8 (*)(u32,  u8 *, u16 *)' {aka 'unsigned char (*)(unsigned int,  unsigned char *, short unsigned int *)'} [-Werror=cast-function-type]
  /*.format_fw_ver= */(format_fw_ver_t)elink_format_ver,
                      ^
../../common/io/bnxe/577xx/common/bnxe_clc.c:12672:21: error: cast between incompatible function types from 'elink_status_t (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)' {aka 'enum elink_status (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)'} to 'u8 (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)' {aka 'unsigned char (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)'} [-Werror=cast-function-type]
  /*.config_init = */(config_init_t)elink_8726_config_init,
                     ^
../../common/io/bnxe/577xx/common/bnxe_clc.c:12676:22: error: cast between incompatible function types from 'elink_status_t (*)(u32,  u8 *, u16 *)' {aka 'enum elink_status (*)(unsigned int,  unsigned char *, short unsigned int *)'} to 'u8 (*)(u32,  u8 *, u16 *)' {aka 'unsigned char (*)(unsigned int,  unsigned char *, short unsigned int *)'} [-Werror=cast-function-type]
  /*.format_fw_ver= */(format_fw_ver_t)elink_format_ver,
                      ^
../../common/io/bnxe/577xx/common/bnxe_clc.c:12706:21: error: cast between incompatible function types from 'elink_status_t (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)' {aka 'enum elink_status (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)'} to 'u8 (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)' {aka 'unsigned char (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)'} [-Werror=cast-function-type]
  /*.config_init = */(config_init_t)elink_8727_config_init,
                     ^
../../common/io/bnxe/577xx/common/bnxe_clc.c:12710:22: error: cast between incompatible function types from 'elink_status_t (*)(u32,  u8 *, u16 *)' {aka 'enum elink_status (*)(unsigned int,  unsigned char *, short unsigned int *)'} to 'u8 (*)(u32,  u8 *, u16 *)' {aka 'unsigned char (*)(unsigned int,  unsigned char *, short unsigned int *)'} [-Werror=cast-function-type]
  /*.format_fw_ver= */(format_fw_ver_t)elink_format_ver,
                      ^
../../common/io/bnxe/577xx/common/bnxe_clc.c:12745:21: error: cast between incompatible function types from 'elink_status_t (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)' {aka 'enum elink_status (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)'} to 'u8 (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)' {aka 'unsigned char (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)'} [-Werror=cast-function-type]
  /*.config_init = */(config_init_t)elink_8481_config_init,
                     ^
../../common/io/bnxe/577xx/common/bnxe_clc.c:12749:22: error: cast between incompatible function types from 'elink_status_t (*)(u32,  u8 *, u16 *)' {aka 'enum elink_status (*)(unsigned int,  unsigned char *, short unsigned int *)'} to 'u8 (*)(u32,  u8 *, u16 *)' {aka 'unsigned char (*)(unsigned int,  unsigned char *, short unsigned int *)'} [-Werror=cast-function-type]
  /*.format_fw_ver= */(format_fw_ver_t)elink_848xx_format_ver,
                      ^
../../common/io/bnxe/577xx/common/bnxe_clc.c:12784:21: error: cast between incompatible function types from 'elink_status_t (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)' {aka 'enum elink_status (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)'} to 'u8 (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)' {aka 'unsigned char (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)'} [-Werror=cast-function-type]
  /*.config_init = */(config_init_t)elink_848x3_config_init,
                     ^
../../common/io/bnxe/577xx/common/bnxe_clc.c:12788:22: error: cast between incompatible function types from 'elink_status_t (*)(u32,  u8 *, u16 *)' {aka 'enum elink_status (*)(unsigned int,  unsigned char *, short unsigned int *)'} to 'u8 (*)(u32,  u8 *, u16 *)' {aka 'unsigned char (*)(unsigned int,  unsigned char *, short unsigned int *)'} [-Werror=cast-function-type]
  /*.format_fw_ver= */(format_fw_ver_t)elink_848xx_format_ver,
                      ^
../../common/io/bnxe/577xx/common/bnxe_clc.c:12824:21: error: cast between incompatible function types from 'elink_status_t (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)' {aka 'enum elink_status (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)'} to 'u8 (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)' {aka 'unsigned char (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)'} [-Werror=cast-function-type]
  /*.config_init = */(config_init_t)elink_848x3_config_init,
                     ^
../../common/io/bnxe/577xx/common/bnxe_clc.c:12828:22: error: cast between incompatible function types from 'elink_status_t (*)(u32,  u8 *, u16 *)' {aka 'enum elink_status (*)(unsigned int,  unsigned char *, short unsigned int *)'} to 'u8 (*)(u32,  u8 *, u16 *)' {aka 'unsigned char (*)(unsigned int,  unsigned char *, short unsigned int *)'} [-Werror=cast-function-type]
  /*.format_fw_ver= */(format_fw_ver_t)elink_848xx_format_ver,
                      ^
../../common/io/bnxe/577xx/common/bnxe_clc.c:12829:18: error: cast between incompatible function types from 'elink_status_t (*)(struct elink_phy *, struct elink_params *)' {aka 'enum elink_status (*)(struct elink_phy *, struct elink_params *)'} to 'void (*)(struct elink_phy *, struct elink_params *)' [-Werror=cast-function-type]
  /*.hw_reset = */(hw_reset_t)elink_84833_hw_reset_phy,
                  ^
../../common/io/bnxe/577xx/common/bnxe_clc.c:12860:21: error: cast between incompatible function types from 'elink_status_t (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)' {aka 'enum elink_status (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)'} to 'u8 (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)' {aka 'unsigned char (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)'} [-Werror=cast-function-type]
  /*.config_init = */(config_init_t)elink_848x3_config_init,
                     ^
../../common/io/bnxe/577xx/common/bnxe_clc.c:12864:22: error: cast between incompatible function types from 'elink_status_t (*)(u32,  u8 *, u16 *)' {aka 'enum elink_status (*)(unsigned int,  unsigned char *, short unsigned int *)'} to 'u8 (*)(u32,  u8 *, u16 *)' {aka 'unsigned char (*)(unsigned int,  unsigned char *, short unsigned int *)'} [-Werror=cast-function-type]
  /*.format_fw_ver= */(format_fw_ver_t)elink_848xx_format_ver,
                      ^
../../common/io/bnxe/577xx/common/bnxe_clc.c:12865:18: error: cast between incompatible function types from 'elink_status_t (*)(struct elink_phy *, struct elink_params *)' {aka 'enum elink_status (*)(struct elink_phy *, struct elink_params *)'} to 'void (*)(struct elink_phy *, struct elink_params *)' [-Werror=cast-function-type]
  /*.hw_reset = */(hw_reset_t)elink_84833_hw_reset_phy,
                  ^
../../common/io/bnxe/577xx/common/bnxe_clc.c:12898:21: error: cast between incompatible function types from 'elink_status_t (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)' {aka 'enum elink_status (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)'} to 'u8 (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)' {aka 'unsigned char (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)'} [-Werror=cast-function-type]
  /*.config_init = */(config_init_t)elink_54618se_config_init,
                     ^
cc1: all warnings being treated as errors

Testing Done

Issues

0
0
2
1
All Issues: 3

Description	From	Last Updated
Should these be ELINK_STATUS_OK since we're trying to return a status? Assuming it's really OK.	rm	Sept. 27, 2019, 8:04 p.m.
This seems to constitute a change in behaviour. Are we absolutely certain that there isn't hardware out there that is ...	andy_js	Oct. 4, 2019, 11:10 a.m.
Shouldn't this be ELINK_STATUS_OK?	rm	Oct. 10, 2019, 6:17 a.m.

Ship it!

```
Ship It!
```

usr/src/uts/common/io/bnxe/577xx/common/bnxe_clc.c (Diff revision 1)

Show all issues

Should these be ELINK_STATUS_OK since we're trying to return a status? Assuming it's really OK.

tsoome Sept. 27, 2019, 8:05 p.m.

The code does not really check the return codes, but I did use error and ok.

andy_js Oct. 4, 2019, 11:12 a.m.

I would be inclined to return ELINK_STATUS_OK everywhere even though the value isn't being checked.

Commit:

-	ef2c02cabf8746fe7b5f730ec9f003d2bed0f334
+	7ab3d1bfd091b0a59ff31b72270b6bd6a3656f9c

Diff:

Revision 2 (+150 -146)

Show changes

	usr/src/uts/common/io/bnxe/577xx/common/bnxe_clc.c
	usr/src/uts/common/io/bnxe/577xx/hsi/hw/include/clc.h

usr/src/uts/common/io/bnxe/577xx/common/bnxe_clc.c (Diff revision 2)

Show all issues

This seems to constitute a change in behaviour. Are we absolutely certain that there isn't hardware out there that is going to stop working because of this?

tsoome Oct. 4, 2019, 11:06 a.m.

elink_warpcore_config_init() is assigned to struct elink_phy member config_init; and use cases are:
http://src.illumos.org/source/xref/illumos-gate/usr/src/uts/common/io/bnxe/577xx/common/bnxe_clc.c#7259

http://src.illumos.org/source/xref/illumos-gate/usr/src/uts/common/io/bnxe/577xx/common/bnxe_clc.c#7291

http://src.illumos.org/source/xref/illumos-gate/usr/src/uts/common/io/bnxe/577xx/common/bnxe_clc.c#7740
and none of those are checking the return result beingit 0 or anything else...

andy_js Oct. 4, 2019, 11:11 a.m.

That sucks. I guess it won't break anything after all then.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

usr/src/uts/common/io/bnxe/577xx/common/bnxe_clc.c (Diff revision 2)
Show all issues
```
Shouldn't this be ELINK_STATUS_OK?
```

Commit:

-	7ab3d1bfd091b0a59ff31b72270b6bd6a3656f9c
+	2aec221dac622d2b58dfaf807090a2cd5192592c

Diff:

Revision 3 (+150 -146)

Show changes

	usr/src/uts/common/io/bnxe/577xx/common/bnxe_clc.c
	usr/src/uts/common/io/bnxe/577xx/hsi/hw/include/clc.h

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

You have a pending review.

Review Board 3.0.18

11721 bnxe: cast between incompatible function types

Commit:

Diff:

Commit:

Diff:

Status: Closed (submitted)